Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

Missing ngtsc diagnostics for invalid inputs, outputs, queries and signal APIs

未关闭
#508 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
52/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
angular, rust, typescript
领域
compilers

调研方向

Start in crates/oxc_angular_compiler/src/directive/property_decorators.rs and directive/decorator.rs, then compare the corresponding ngtsc checks in shared.ts and input_output_parse_options.ts. Review initializer_api_usage_rule.ts for NG8110. Use the checklist snippets as repro cases; done means the expected diagnostics are emitted and the incorrect bindings, queries, and metadata are no longer produced.

由索引模型根据 Issue 内容生成。

描述

bug

ngtsc 22.1.7 rejects each form below. OXC (main and #504 tip, 3e0b07f) compiles them with no diagnostic. Often the output is wrong too: a binding is dropped, duplicated, or a query is registered twice.

Each snippet uses import {Component, Directive, Input, Output, EventEmitter, ViewChild, ContentChild, input, output, viewChild, model} from '@angular/core';.

Checklist

ngtsc message is exact (codes shown as NGxxxx). The OXC column is #504 tip; main is the same.

  • Decorator on a signal query. @ViewChild('a') q = viewChild('a');
    ngtsc: NG1050: Using @ViewChild with a signal-based query is not allowed. (same for @ContentChild etc.)
    OXC: no error. Emits a decorator ɵɵviewQuery.
  • input() / model() not used directly as a field initializer. a = input(0)!;, m = model(0)!;, a = input(0) satisfies any;, constructor() { const x = input(0); }
    ngtsc: NG8110: Unsupported call to the input function. This function can only be called in the initializer of a class member. (model gives "...the model function...")
    OXC: no error. The input is silently left out of inputs.
  • Signal API on a private / #private member. private a = input(0); / #a = input(0);
    ngtsc: NG1053: Cannot use "input" on a class member that is declared as private. Update the class field to be either: public, public readonly, protected (... declared as ES private. ... for #a)
    OXC: no error. private compiles as a normal input. #a is silently dropped.
  • Signal option alias is not a string literal. a = input(0, {alias: 1 as any});, o = output({alias: 1 as any});, and input(0, {alias: ALIAS}) with ALIAS imported from another file
    ngtsc: NG1010: Alias needs to be a string that is statically analyzable.
    OXC: no error. The alias is ignored (inputs:{a:[1,"a"]}, outputs:{o:"o"}).
  • Two members bound to the same public name. @Input('y') x: any; @Input() y: any;
    ngtsc: NG1054: Input 'y' is bound to both 'x' and 'y'.
    Same for outputs: NG1054: Output 'y' is bound to both 'x' and 'y'.
    OXC: no error. Both are emitted (outputs:{x:"y",y:"y"}).
  • Two query decorators on one member. @ViewChild('a') @ContentChild('b') q: any;
    ngtsc: NG1006: Cannot combine multiple query decorators.
    OXC: no error. Emits both a contentQuery and a viewQuery writing to ctx.q.
  • @Input together with a query decorator. @Input() @ViewChild('a') q: any;
    ngtsc: NG1006: Cannot combine @Input decorators with query decorators
    OXC: no error. Emits both inputs:{q:"q"} and a viewQuery.
  • Static members.
    • @Input() static a: any; → NG1100: Input "a" is incorrectly declared as static member of "D".
    • @ViewChild('a') static q: any; → NG1100: Query is incorrectly declared on a static class member.
    • @Output() static o = new EventEmitter(); → NG1100: Output is incorrectly declared on a static class member.
      OXC: no error. All three are emitted as if they were instance members.
  • @Output() on a setter. @Output() set o(v: any) {}
    ngtsc compiles it: outputs: { o: "o" }. With a bad argument, @Output(1 as any) set o(v: any) {}, it reports NG1010: @Output decorator argument must resolve to a string Value is of type 'number'.
    OXC: drops the output (no outputs, {} in .d.ts) and does not check the argument.
  • Directive with selector: ''. @Directive({selector: ''}) export class D {}
    ngtsc: NG2004: Directive D has no selector, please add it!
    OXC: no error. Emits ɵɵdefineDirective({type:D}) and "" as the .d.ts selector. (Components with selector: '' are tracked separately.)

Where ngtsc raises them (Angular v22.0.0 source)

  • packages/compiler-cli/src/ngtsc/annotations/directive/src/shared.ts: NG2004, NG1006 ×2, NG1054 ×2, NG1100 ×3, NG1050
  • .../annotations/directive/src/initializer_function_access.ts: NG1053
  • .../annotations/directive/src/input_output_parse_options.ts: alias NG1010
  • .../validation/src/rules/initializer_api_usage_rule.ts: NG8110 (a source-file check, not part of the decorator handler)

On the OXC side, most belong in crates/oxc_angular_compiler/src/directive/property_decorators.rs and directive/decorator.rs.

On main?

Yes, all of them. The stack doesn't change these cases.

主要语言
Rust
星标
232
派生
21
平均合并
1 天 23 小时
30 天内合并 PR
53

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

voidzero-dev/oxc-angular-compiler 的其他 Issue

查看 voidzero-dev/oxc-angular-compiler 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。