Hacktoberfest 2026:維護者為十月標記出來的 issue,仍然開放、適合新手。 瀏覽 Hacktoberfest issue

fix(directive): input names with lone surrogates are emitted in oxc's internal U+FFFD encoding

未關閉
#505 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
68/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
angular, rust, typescript
領域
compilers

研究方向

Start with get_property_key_name in directive/property_decorators.rs and its copied decorator helpers, then trace class_metadata/builders.rs and the JS and dts.rs emitters. Use the lone-surrogate repro to compare OXC output with ngtsc; done means names and string values preserve lone code units as writable \uXXXX escapes and the generated TypeScript is valid.

由索引模型根據 Issue 內容生成。

描述

bug

A member name written with a lone surrogate escape ('x-\uD800') comes out of OXC as x-<U+FFFD>d800: U+FFFD followed by the hex code unit. This is how oxc_ast stores lone surrogates in StringLiteral::value when lone_surrogates is true. We use value as a normal string and never decode it. ngtsc writes \uD800.

So the binding name at runtime (x-<U+FFFD>d800) doesn't match the class field (x-\uD800).

Repro

import {Directive, Input} from '@angular/core';
@Directive({selector: '[d]'})
export class D {
  @Input() 'x-\uD800': any;
  @Input({transform: (v: string) => 1}) 'y-\uD800': number = 0;
}

OXC (#504 tip, 3e0b07f). � below is the U+FFFD character

static ɵdir = i0.ɵɵdefineDirective({type:D,selectors:[["","d",""]],inputs:{"x-�d800":"x-�d800",
    "y-�d800":[2,"y-�d800","y-�d800",(v) =>1]}});
// setClassMetadata
{"x-�d800":[{type:Input}],"y-�d800":[{type:Input,args:[{transform:(v) =>1}]}]}
static ɵdir: i0.ɵɵDirectiveDeclaration<D, "[d]", never, { "x-�d800": { "alias": "x-�d800"; "required": false; }; "y-�d800": { "alias": "y-�d800"; "required": false; }; }, {}, never, never, true, never>;
static "ngAcceptInputType_y-�d800": string;

ngtsc 22.1.7

static ɵdir = i0.ɵɵdefineDirective({ type: D, selectors: [["", "d", ""]], inputs: { "x-\uD800": "x-\uD800", "y-\uD800": [2, "y-\uD800", "y-\uD800", (v) => 1] } });
// setClassMetadata
{ "x-\uD800": [{ type: Input }], "y-\uD800": [{ type: Input, args: [{ transform: (v) => 1 }] }] }
static ɵdir: i0.ɵɵDirectiveDeclaration<D, "[d]", never, { "x-\uD800": { "alias": "x-\uD800"; "required": false; }; "y-\uD800": { "alias": "y-\uD800"; "required": false; }; }, {}, never, never, true, never>;
static "ngAcceptInputType_y-\uD800": string;

Where

  • Main and the stack both read the key with .value: directive/property_decorators.rs (get_property_key_name) and class_metadata/builders.rs (get_property_key_name). The same helper is copied into the component, pipe, NgModule, injectable and service decorator modules.
  • Strings are printed by the JS emitter and by dts.rs (escape_dts_string, and the ngAcceptInputType_ quoting in generate_input_transform_fields). None of them handle the encoding.

On main?

Yes. On main the field is printed unquoted, static ngAcceptInputType_y-�d800: unknown;, which is not valid TS. The stack (#496) quotes it and types it, but the name still uses the internal encoding.

Direction

Decode lone_surrogates strings when reading names and string values. Keep the lone code units in a form the emitters can write back as \uXXXX.

主要語言
Rust
星號
240
分支
24
平均合併
1 天 16 小時
30 天內合併 PR
72

環境準備

這個專案沒有提供開發容器、Dockerfile 或貢獻指南,環境需要你自己搭建:先看它的 README,通用步驟見我們的新手貢獻指南。

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

voidzero-dev/oxc-angular-compiler 的其他 Issue

查看 voidzero-dev/oxc-angular-compiler 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。