docs(source-control): stop a HIGH or CRITICAL merge-risk merge for the owner only on token, account or billing risk

未關閉
#17,849 3 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

@kyle-sexton 已經在處理了。

開始於 2026年11月21日。

  • #17842 來自 @kyle-sexton —— 未關閉

評估

難度
2/5
預估耗時
1 小時以內
新手友好度
18/100
Issue 類型
文件
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
markdown
領域
documentation

研究方向

The rule lives in plugins/source-control/skills/pull-request/reference/merge.md under §4.2.1, and the changelog fragment goes in .changes/source-control/. The issue says this is already delivered by open pull request #17842, so check that PR first before writing anything. Done means §4.2.1 states the narrowed token, account or billing boundary and a minor fragment exists. The issue is a policy-wording change to a merge guard, so confirm the owner's intent with maintainers before editing.

由索引模型根據 Issue 內容生成。

描述

Problem

plugins/source-control/skills/pull-request/reference/merge.md §4.2.1 makes a session's merge of a pull request rated HIGH or CRITICAL for merge risk (demote=true) stop for the owner on every reason no owner decision covers. The owner's standing direction limits the high/critical boundary to a token or secret leak, an account compromise, or a cost to the owner, so every other uncovered reason sends work to him that the boundary does not need.

Change, including the loosening it makes

This loosens a merge guard on purpose. Today a demoted merge goes to the owner for any HIGH or CRITICAL reason no owner decision covers. After the change, merge.md §4.2.1 stops a demoted merge for the owner only when an uncovered reason is a token or secret leak risk, an account-compromise risk, or something that can bill the owner. Any other uncovered reason is named in one PR comment and the merge proceeds. A reason the session cannot read still holds, and a missing rating still blocks the merge. The .changes/source-control/ fragment records the same change.

Owner decision: https://github.com/melodic-software/architecture/blob/34207b542ebb28c2b7a5a1ed60046ea3d9d83639/docs/owner-decisions.md#L290, verbatim: "Yeah, let's go with recommendations"

Standing direction §10, verbatim: "Section 3's 'high/critical boundary' means only: a token or secret leaking, my accounts being compromised, or anything that bills me. Nothing else qualifies."

Done when

  • merge.md §4.2.1 states the rule above, and a minor changelog fragment under .changes/source-control/ records it.

Delivered by #17842, which is open; no other pull request is needed.

主要語言
Shell
星號
22
分支
2
平均合併
2 小時 17 分鐘
30 天內合併 PR
960

環境準備

  • 沒有 Dockerfile 或 Docker Compose 檔案
  • 沒有 Pull Request 範本
  • 閱讀貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

melodic-software/claude-code-plugins 的其他 Issue

查看 melodic-software/claude-code-plugins 的全部 Issue

相似的 Issue

更多 Shell/Bash Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。