docs(source-control): stop a HIGH or CRITICAL merge-risk merge for the owner only on token, account or billing risk

Ouverte
#17,849 3 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

@kyle-sexton y travaille déjà.

Depuis le 21/11/2026.

  • #17842 par @kyle-sexton — ouverte

Évaluation

Difficulté
2/5
Temps estimé
Moins d'une heure
Accessibilité débutants
18/100
Type d'issue
Documentation
Clarté
Plutôt claire
Activité
Active
Stack technique
markdown
Domaine
documentation

Piste de recherche

The rule lives in plugins/source-control/skills/pull-request/reference/merge.md under §4.2.1, and the changelog fragment goes in .changes/source-control/. The issue says this is already delivered by open pull request #17842, so check that PR first before writing anything. Done means §4.2.1 states the narrowed token, account or billing boundary and a minor fragment exists. The issue is a policy-wording change to a merge guard, so confirm the owner's intent with maintainers before editing.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Problem

plugins/source-control/skills/pull-request/reference/merge.md §4.2.1 makes a session's merge of a pull request rated HIGH or CRITICAL for merge risk (demote=true) stop for the owner on every reason no owner decision covers. The owner's standing direction limits the high/critical boundary to a token or secret leak, an account compromise, or a cost to the owner, so every other uncovered reason sends work to him that the boundary does not need.

Change, including the loosening it makes

This loosens a merge guard on purpose. Today a demoted merge goes to the owner for any HIGH or CRITICAL reason no owner decision covers. After the change, merge.md §4.2.1 stops a demoted merge for the owner only when an uncovered reason is a token or secret leak risk, an account-compromise risk, or something that can bill the owner. Any other uncovered reason is named in one PR comment and the merge proceeds. A reason the session cannot read still holds, and a missing rating still blocks the merge. The .changes/source-control/ fragment records the same change.

Owner decision: https://github.com/melodic-software/architecture/blob/34207b542ebb28c2b7a5a1ed60046ea3d9d83639/docs/owner-decisions.md#L290, verbatim: "Yeah, let's go with recommendations"

Standing direction §10, verbatim: "Section 3's 'high/critical boundary' means only: a token or secret leaking, my accounts being compromised, or anything that bills me. Nothing else qualifies."

Done when

  • merge.md §4.2.1 states the rule above, and a minor changelog fragment under .changes/source-control/ records it.

Delivered by #17842, which is open; no other pull request is needed.

Langage dominant
Shell
Étoiles
22
Forks
2
Merge moyen
2 h 17 min
PR mergées (30 j)
960

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de melodic-software/claude-code-plugins

Toutes les issues de melodic-software/claude-code-plugins

Issues similaires

Plus d'issues Shell/Bash

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.