docs(source-control): stop a HIGH or CRITICAL merge-risk merge for the owner only on token, account or billing risk

Aperta
#17,849 3 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@kyle-sexton ci sta già lavorando.

Dal 21/11/2026.

  • #17842 di @kyle-sexton — aperta

Valutazione

Difficoltà
2/5
Tempo stimato
Meno di un'ora
Idoneità per principianti
18/100
Tipo di issue
Documentazione
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
markdown
Ambito
documentation

Direzione di ricerca

The rule lives in plugins/source-control/skills/pull-request/reference/merge.md under §4.2.1, and the changelog fragment goes in .changes/source-control/. The issue says this is already delivered by open pull request #17842, so check that PR first before writing anything. Done means §4.2.1 states the narrowed token, account or billing boundary and a minor fragment exists. The issue is a policy-wording change to a merge guard, so confirm the owner's intent with maintainers before editing.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Problem

plugins/source-control/skills/pull-request/reference/merge.md §4.2.1 makes a session's merge of a pull request rated HIGH or CRITICAL for merge risk (demote=true) stop for the owner on every reason no owner decision covers. The owner's standing direction limits the high/critical boundary to a token or secret leak, an account compromise, or a cost to the owner, so every other uncovered reason sends work to him that the boundary does not need.

Change, including the loosening it makes

This loosens a merge guard on purpose. Today a demoted merge goes to the owner for any HIGH or CRITICAL reason no owner decision covers. After the change, merge.md §4.2.1 stops a demoted merge for the owner only when an uncovered reason is a token or secret leak risk, an account-compromise risk, or something that can bill the owner. Any other uncovered reason is named in one PR comment and the merge proceeds. A reason the session cannot read still holds, and a missing rating still blocks the merge. The .changes/source-control/ fragment records the same change.

Owner decision: https://github.com/melodic-software/architecture/blob/34207b542ebb28c2b7a5a1ed60046ea3d9d83639/docs/owner-decisions.md#L290, verbatim: "Yeah, let's go with recommendations"

Standing direction §10, verbatim: "Section 3's 'high/critical boundary' means only: a token or secret leaking, my accounts being compromised, or anything that bills me. Nothing else qualifies."

Done when

  • merge.md §4.2.1 states the rule above, and a minor changelog fragment under .changes/source-control/ records it.

Delivered by #17842, which is open; no other pull request is needed.

Lingua principale
Shell
Stelle
22
Fork
2
Merge medio
2h 17m
PR unite (30g)
960

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di melodic-software/claude-code-plugins

Tutte le issue di melodic-software/claude-code-plugins

Issue simili

Altre issue su Shell/Bash

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.