docs(source-control): stop a HIGH or CRITICAL merge-risk merge for the owner only on token, account or billing risk

Aberta
#17,849 3 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

@kyle-sexton já está trabalhando nisso.

Desde 21/11/2026.

  • #17842 de @kyle-sexton — aberto

Avaliação

Dificuldade
2/5
Tempo estimado
Menos de uma hora
Facilidade para iniciantes
18/100
Tipo de issue
Documentação
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
markdown
Domínio
documentation

Direção de pesquisa

The rule lives in plugins/source-control/skills/pull-request/reference/merge.md under §4.2.1, and the changelog fragment goes in .changes/source-control/. The issue says this is already delivered by open pull request #17842, so check that PR first before writing anything. Done means §4.2.1 states the narrowed token, account or billing boundary and a minor fragment exists. The issue is a policy-wording change to a merge guard, so confirm the owner's intent with maintainers before editing.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Problem

plugins/source-control/skills/pull-request/reference/merge.md §4.2.1 makes a session's merge of a pull request rated HIGH or CRITICAL for merge risk (demote=true) stop for the owner on every reason no owner decision covers. The owner's standing direction limits the high/critical boundary to a token or secret leak, an account compromise, or a cost to the owner, so every other uncovered reason sends work to him that the boundary does not need.

Change, including the loosening it makes

This loosens a merge guard on purpose. Today a demoted merge goes to the owner for any HIGH or CRITICAL reason no owner decision covers. After the change, merge.md §4.2.1 stops a demoted merge for the owner only when an uncovered reason is a token or secret leak risk, an account-compromise risk, or something that can bill the owner. Any other uncovered reason is named in one PR comment and the merge proceeds. A reason the session cannot read still holds, and a missing rating still blocks the merge. The .changes/source-control/ fragment records the same change.

Owner decision: https://github.com/melodic-software/architecture/blob/34207b542ebb28c2b7a5a1ed60046ea3d9d83639/docs/owner-decisions.md#L290, verbatim: "Yeah, let's go with recommendations"

Standing direction §10, verbatim: "Section 3's 'high/critical boundary' means only: a token or secret leaking, my accounts being compromised, or anything that bills me. Nothing else qualifies."

Done when

  • merge.md §4.2.1 states the rule above, and a minor changelog fragment under .changes/source-control/ records it.

Delivered by #17842, which is open; no other pull request is needed.

Linguagem predominante
Shell
Estrelas
22
Forks
2
Merge médio
2h 17min
PRs com merge (30d)
960

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de melodic-software/claude-code-plugins

Todas as issues de melodic-software/claude-code-plugins

Issues semelhantes

Mais issues de Shell/Bash

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.