Hacktoberfest 2026:維護者為十月標記出來的 issue,仍然開放、適合新手。 瀏覽 Hacktoberfest issue

[Bug] Flaky SIGSEGV in VariantParquetTest: Arrow IO thread frees PoolBuffer after the test's memory pool is destroyed

未關閉
#385 0 則留言 0 個 reaction 已指派 1 人 在 GitHub 檢視

@SteNicholas 已經在處理了。

開始於 2026年9月23日。

評估

這個 Issue 還沒有評估資料。

描述

bug
Search before asking
  • I searched in the issues and found nothing similar.
Paimon-cpp version

main, observed on commit dc745fe91932dc2cba919fb13639dfc427280006 (the change in that commit only touches realtime/, unrelated to this failure).

Minimal reproduce step

Flaky; observed in CI job gcc-release-x86_64: https://github.com/apache/paimon-cpp/actions/runs/35845901520/job/107134278444

paimon-parquet-format-test crashes with SIGSEGV right after VariantParquetTest.WriteAndReadRoundTrip passes, while VariantParquetTest.ShreddedWriteAndReadRoundTrip is starting:

[ RUN      ] VariantParquetTest.ShreddedWriteAndReadRoundTrip
build_support/run-test.sh: line 98: 67868 Segmentation fault      (core dumped)
Program terminated with signal SIGSEGV, Segmentation fault.

Thread 1 (Arrow IO thread pool):
#0 arrow::PoolBuffer::~PoolBuffer()
#1 arrow::Future<std::shared_ptr<arrow::Buffer>>::SetResult(...)::{lambda(void*)#1}::_FUN(void*)
#2 arrow::ConcreteFutureImpl::~ConcreteFutureImpl()
#3 std::_Sp_counted_base<...>::_M_release_last_use_cold()
#4 arrow::internal::FnOnce<void ()>::FnImpl<std::_Bind<arrow::detail::ContinueFuture (arrow::Future<std::shared_ptr<arrow::Buffer>>, arrow::io::RandomAccessFile::ReadAsync(arrow::io::IOContext const&, long, long)::{lambda()#1})>>::~FnImpl()
#5 arrow::internal::ThreadPool::LaunchWorkersUnlocked(int)::{lambda()#1} ...

The main thread is already running the next test (VariantShreddingWritePlan::CreateFromPhysicalSchema) and is unrelated to the crash.

What doesn't meet your expectations?

The test binary should not crash. The crash is a use-after-free of the Arrow memory pool in the test fixture:

  1. VariantParquetTest::SetUp() creates a per-test pool adaptor: arrow_pool_ = GetArrowPool(pool_); (src/paimon/format/parquet/variant_parquet_test.cpp). It is destroyed together with the fixture.
  2. Several tests (WriteAndReadRoundTrip, ShreddedWriteAndReadRoundTrip, and the helper around line 548) open the file for a raw sanity check with the plain Arrow reader:
    auto file = arrow::io::ReadableFile::Open(file_path_, arrow_pool_.get());
    ::parquet::arrow::OpenFile(file.ValueOrDie(), arrow_pool_.get(), &raw_reader);
    
    Only the raw arrow::MemoryPool* is passed, so nothing keeps the adaptor alive.
  3. With Arrow 17, ArrowReaderProperties::pre_buffer() defaults to true, so ReadTable issues RandomAccessFile::ReadAsync. ReadableFile does not override it, so the base implementation submits ReadAt to the IO thread pool and the result PoolBuffer is allocated from arrow_pool_.
  4. The IO worker holds the last reference to the future (and therefore the buffer) until its task object is destroyed, which can happen after the reader has consumed the data and the test has finished. When the fixture is torn down first, ~PoolBuffer() calls Free() on the already destroyed adaptor -> SIGSEGV.

Paimon's own read path (ArrowInputStreamAdapter::ReadAsync) is not affected: it uses a callback-based implementation and already retains the pool with the returned buffer (#182). This issue is limited to tests that use arrow::io::ReadableFile with a raw pointer to a short-lived pool.

Anything else?

Possible fixes (test-only):

  • Use a process-lifetime Arrow pool for these raw sanity-check readers, e.g. arrow::default_memory_pool(), instead of the per-fixture arrow_pool_.get(); or
  • Disable pre-buffering for the raw reader (ArrowReaderProperties::set_pre_buffer(false)), so no async IO task outlives the test; or
  • Read through ArrowInputStreamAdapter, which keeps the pool alive for returned buffers.

Other tests using arrow::io::ReadableFile::Open(..., pool.get()) with a per-test pool may have the same latent issue and should be checked as well.

主要語言
C++
星號
65
分支
29
平均合併
2 天 11 小時
30 天內合併 PR
79

貢獻指南

開啟貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

apache/paimon-cpp 的其他 Issue

查看 apache/paimon-cpp 的全部 Issue

相似的 Issue

更多 C++ Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。