[Feature] Bypass manifest lists on exact snapshot live-entry cache hits

未關閉
#375 0 則留言 0 個 reaction 已指派 1 人 在 GitHub 檢視

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
30/100
Issue 類型
功能
描述清晰度
基本清楚
活躍度
停滯
技術堆疊
cpp
領域
databases

研究方向

Start with AppendOnlyFileStoreScanTest.TestSnapshotLiveManifestCachePath and the public orc/append_09.db/append_09 fixture, using snapshot 5 and bucket 0 to reproduce the cache-hit path. Review draft implementation #374 and its focused regression tests for manifest-cache access counts, changed predicates, eviction/rebuild, and retained file counts. Done means eligible exact hits skip manifest reads and decoding while misses rebuild completely and filters, snapshot identity, and metrics remain correct.

由索引模型根據 Issue 內容生成。

描述

Search before asking
  • I searched existing issues and found no report of this exact-hit planning overhead.
Motivation

Repeated scans of the same snapshot and bucket still read and decode the manifest lists before checking the snapshot live-manifest-entry cache. The cached live entries already contain the state needed for that bucket, so this work adds avoidable CPU and metadata access to repeated point-read planning.

To reproduce, use the public orc/append_09.db/append_09 test fixture with snapshot 5 and bucket 0, enable the snapshot live-manifest-entry cache, and reuse one cache across two scans. Instrument the MANIFEST cache accesses, as in AppendOnlyFileStoreScanTest.TestSnapshotLiveManifestCachePath. Before the proposed change, the second scan revisits the manifest-list path even though its exact snapshot/bucket live-entry lookup hits.

Expected: an eligible exact hit bypasses manifest-list reads and decoding, while each request still applies its own filters. A miss must rebuild the complete bucket. Snapshot selection and the existing snapshot-identity validation must remain intact.

Solution

Resolve the snapshot first and consult the existing snapshot live-entry cache before reading manifest lists. Retain the table file count in the transient cached payload so skipped-file metrics remain correct; report zero scanned manifests for an exact hit. Version the transient payload so incompatible entries fall back to rebuilding.

Draft implementation: #374. Regression tests check the manifest-cache access count, changed predicates, eviction/rebuild, and retained file counts. This change does not introduce a filesystem block cache or alter the persisted table format.

Anything else?

The identical patch passed 88 focused tests in a downstream C++17 Release build. Upstream CI for the draft still requires maintainer approval; no standalone end-to-end performance uplift is claimed for this individual optimization.

Are you willing to submit a PR?
  • I am willing to submit a PR; #374 is available as a draft.
主要語言
C++
星號
65
分支
29
平均合併
2 天 30 分鐘
30 天內合併 PR
77

貢獻指南

開啟貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

apache/paimon-cpp 的其他 Issue

查看 apache/paimon-cpp 的全部 Issue

相似的 Issue

更多 C++ Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。