Item tooltip comparison and unique "Sort by" ignore skills granted by the candidate item
維護者通常 8 天內回覆
還沒有人認領這個 Issue。
評估
研究方向
Start with the granted-skill handling in src/Modules/CalcSetup.lua, especially the sections around lines 846, 1465–1520, and 1566–1578; then trace the CALCULATOR-mode comparison paths in Calcs.lua, ItemDBControl.lua, and ItemsTab.lua. Check how candidate item skills and removed item groups are represented in non-MAIN calculations. Done means item comparison tooltips and unique-item sorting include skills granted by the candidate, while replacement comparisons also handle the prior granted skill correctly.
由索引模型根據 Issue 內容生成。
描述
What happens
Comparisons for an item that is not equipped (the unique/rare database "Sort by" stat sort and the item hover tooltip "Equipping this item will give you") never include a skill that the candidate item itself grants. The skill only starts to count after the item is actually equipped.
Example (derived from the code, not yet checked in the UI):
- Make a build whose main skill deals chaos damage with spells or attacks, and equip any one-handed sword.
- Items tab > Uniques, filter to One Handed Swords, hover United in Dream (Grants Level 25 Envy Skill). Or sort the list by Combined DPS.
- Equip United in Dream.
Expected: the tooltip/sort value predicts the DPS you get after equipping, including the added chaos damage from Envy.
Actual: the tooltip/sort value is computed without Envy. After equipping, DPS is higher than predicted, and items that grant skills (auras, buffs, triggered skills) sort lower than they should.
This is the other half of #8093 (that issue is about an equipped item's granted skill still being counted when the candidate replaces it). Both come from the same code path.
Cause
Socket groups for item- and tree-granted skills are only created or removed when env.mode == "MAIN":
- https://github.com/PathOfBuildingCommunity/PathOfBuilding/blob/a69391d6daaaea1aaf8054668a094aad88dd7eaa/src/Modules/CalcSetup.lua#L1468
- https://github.com/PathOfBuildingCommunity/PathOfBuilding/blob/a69391d6daaaea1aaf8054668a094aad88dd7eaa/src/Modules/CalcSetup.lua#L1480-L1520 (create or update the group for each entry in
env.grantedSkills) - https://github.com/PathOfBuildingCommunity/PathOfBuilding/blob/a69391d6daaaea1aaf8054668a094aad88dd7eaa/src/Modules/CalcSetup.lua#L1566-L1578 (remove groups whose item is gone)
The item comparisons run in "CALCULATOR" mode with a repSlotName/repItem override:
- https://github.com/PathOfBuildingCommunity/PathOfBuilding/blob/a69391d6daaaea1aaf8054668a094aad88dd7eaa/src/Modules/Calcs.lua#L100-L101
- https://github.com/PathOfBuildingCommunity/PathOfBuilding/blob/a69391d6daaaea1aaf8054668a094aad88dd7eaa/src/Classes/ItemDBControl.lua#L258-L263
- https://github.com/PathOfBuildingCommunity/PathOfBuilding/blob/a69391d6daaaea1aaf8054668a094aad88dd7eaa/src/Classes/ItemsTab.lua#L2578-L2579
In that mode env.grantedSkills does include the candidate's skill (CalcSetup.lua#L846, #L1465), but no socket group is made for it. Skill building only walks build.skillsTab.socketGroupList, so the candidate's skill never becomes an active skill in the comparison.
Possible fix
Work out the granted-skill groups for the env being calculated in every mode. In non-MAIN modes, build them into a per-env list instead of skipping them, and skip existing granted groups whose source item is not in env.player.itemList. MAIN mode keeps writing them to socketGroupList as it does now. That would also fix #8093.
- 主要語言
- Lua
- 星號
- 5.5k
- 分支
- 2.4k
- 平均合併
- 6 天 14 小時
- 30 天內合併 PR
- 13
環境準備
- 提供 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
PathOfBuildingCommunity/PathOfBuilding 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 75/100
PathOfBuildingCommunity/PathOfBuilding#10431 ·
維護者通常 8 天內回覆
-
難度 2/5 1-3 小時 新手友好度 79/100
PathOfBuildingCommunity/PathOfBuilding#10428 ·
維護者通常 8 天內回覆
-
enhancement
難度 2/5 1-3 小時 新手友好度 60/100
PathOfBuildingCommunity/PathOfBuilding#10420 ·
維護者通常 8 天內回覆
-
enhancement
難度 2/5 1-3 小時 新手友好度 65/100
PathOfBuildingCommunity/PathOfBuilding#10395 ·
維護者通常 8 天內回覆
-
bug: accuracy
難度 2/5 1-3 小時 新手友好度 68/100
PathOfBuildingCommunity/PathOfBuilding#9911 ·
維護者通常 8 天內回覆
查看 PathOfBuildingCommunity/PathOfBuilding 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 72/100
維護者通常 5 天內回覆
-
enhancement priority::low upstream
難度 2/5 1-3 小時 新手友好度 78/100
維護者通常 1 天內回覆
-
bug reviewed-by-AI
難度 2/5 1-3 小時 新手友好度 82/100
olimorris/codecompanion.nvim#3508 ·
維護者通常 1 天內回覆
-
The Balanced badge stays on a card after it changes to an enhancement that isn't rebalanced可能已有人在做 @Jr-JoshS 今天認領。 未關閉
難度 2/5 1-3 小時 新手友好度 71/100
Balatro-Multiplayer/BalatroMultiplayerPvP#640 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 78/100
Layr-Labs/arena-fortress#141 ·
維護者通常 1 天內回覆