Item tooltip comparison and unique "Sort by" ignore skills granted by the candidate item

Abierto
  • ¿Algo no está bien?
#10,427 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 8 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
55/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
lua
Área
game-dev

Línea de trabajo

Start with the granted-skill handling in src/Modules/CalcSetup.lua, especially the sections around lines 846, 1465–1520, and 1566–1578; then trace the CALCULATOR-mode comparison paths in Calcs.lua, ItemDBControl.lua, and ItemsTab.lua. Check how candidate item skills and removed item groups are represented in non-MAIN calculations. Done means item comparison tooltips and unique-item sorting include skills granted by the candidate, while replacement comparisons also handle the prior granted skill correctly.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

What happens

Comparisons for an item that is not equipped (the unique/rare database "Sort by" stat sort and the item hover tooltip "Equipping this item will give you") never include a skill that the candidate item itself grants. The skill only starts to count after the item is actually equipped.

Example (derived from the code, not yet checked in the UI):

  1. Make a build whose main skill deals chaos damage with spells or attacks, and equip any one-handed sword.
  2. Items tab > Uniques, filter to One Handed Swords, hover United in Dream (Grants Level 25 Envy Skill). Or sort the list by Combined DPS.
  3. Equip United in Dream.

Expected: the tooltip/sort value predicts the DPS you get after equipping, including the added chaos damage from Envy.
Actual: the tooltip/sort value is computed without Envy. After equipping, DPS is higher than predicted, and items that grant skills (auras, buffs, triggered skills) sort lower than they should.

This is the other half of #8093 (that issue is about an equipped item's granted skill still being counted when the candidate replaces it). Both come from the same code path.

Cause

Socket groups for item- and tree-granted skills are only created or removed when env.mode == "MAIN":

The item comparisons run in "CALCULATOR" mode with a repSlotName/repItem override:

In that mode env.grantedSkills does include the candidate's skill (CalcSetup.lua#L846, #L1465), but no socket group is made for it. Skill building only walks build.skillsTab.socketGroupList, so the candidate's skill never becomes an active skill in the comparison.

Possible fix

Work out the granted-skill groups for the env being calculated in every mode. In non-MAIN modes, build them into a per-env list instead of skipping them, and skip existing granted groups whose source item is not in env.player.itemList. MAIN mode keeps writing them to socketGroupList as it does now. That would also fix #8093.

Lenguaje dominante
Lua
Estrellas
5.5k
Forks
2.4k
Merge medio
6 d 14 h
PR fusionados (30 d)
13

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de PathOfBuildingCommunity/PathOfBuilding

Todos los issues de PathOfBuildingCommunity/PathOfBuilding

Issues similares

Más issues de Lua

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.