Follow-ups left open by the pipelined bring-up writes (#417)

未關閉
#435 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
1-2 天
新手友好度
48/100
Issue 類型
缺陷
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
c
領域
backend

研究方向

Read the comments at the relevant sites in src/UsbTransport.cpp and the context and measurements in issue #417. Trace async_write_cb and write_batch_begin, focusing on the completion/free-list handoff and the error-counter reset/generation ordering. Done means both identified pipelined-write races are addressed; the destructor behavior is explicitly a design decision, not a follow-up.

由索引模型根據 Issue 內容生成。

描述

enhancement

Two Qodo threads on #417 were closed without a change when the review cycle was stopped (maintainer decision; merged under skip-qodo-gate). Both are corner cases of the pipelined-write failure paths in UsbTransport, reachable only with two adapters sharing one libusb context in one process, which no demo does today.

  1. Completion counter published before the free-list handoff. async_write_cb increments pool->completed before the mutex-guarded free-list push. A taker on the batch thread that wakes on the counter can find the free list still empty and wait out one more turn. Cost is latency, not correctness. Fix shape: increment completed inside the same critical section as the push, or wake on the free list instead of the counter.

  2. write_errors reset before the generation bump. write_batch_begin clears write_errors and then increments generation. A late callback from a slot of the previous generation that runs between the two stores still compares equal to the old generation and can count into the fresh batch. Fix shape: bump the generation first, then reset the counter.

Also recorded as a deliberate design decision, not a follow-up: a pipelined transfer still submitted after the destructor's cancel + bounded reap is leaked with an error rather than freed or waited on forever (a dead libusb event loop is the only way to get there).

Context and measurements: #417 body; src/UsbTransport.cpp comments at the sites.

主要語言
C
星號
56
分支
29
平均合併
3 小時 43 分鐘
30 天內合併 PR
75

環境準備

這個專案沒有提供開發容器、Dockerfile 或貢獻指南,環境需要你自己搭建:先看它的 README,通用步驟見我們的新手貢獻指南。

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

OpenIPC/devourer 的其他 Issue

查看 OpenIPC/devourer 的全部 Issue

相似的 Issue

更多 C Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。