Follow-ups left open by the pipelined bring-up writes (#417)
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
研究方向
Read the comments at the relevant sites in src/UsbTransport.cpp and the context and measurements in issue #417. Trace async_write_cb and write_batch_begin, focusing on the completion/free-list handoff and the error-counter reset/generation ordering. Done means both identified pipelined-write races are addressed; the destructor behavior is explicitly a design decision, not a follow-up.
由索引模型根據 Issue 內容生成。
描述
Two Qodo threads on #417 were closed without a change when the review cycle was stopped (maintainer decision; merged under skip-qodo-gate). Both are corner cases of the pipelined-write failure paths in UsbTransport, reachable only with two adapters sharing one libusb context in one process, which no demo does today.
-
Completion counter published before the free-list handoff.
async_write_cbincrementspool->completedbefore the mutex-guarded free-list push. A taker on the batch thread that wakes on the counter can find the free list still empty and wait out one more turn. Cost is latency, not correctness. Fix shape: incrementcompletedinside the same critical section as the push, or wake on the free list instead of the counter. -
write_errorsreset before the generation bump.write_batch_beginclearswrite_errorsand then incrementsgeneration. A late callback from a slot of the previous generation that runs between the two stores still compares equal to the old generation and can count into the fresh batch. Fix shape: bump the generation first, then reset the counter.
Also recorded as a deliberate design decision, not a follow-up: a pipelined transfer still submitted after the destructor's cancel + bounded reap is leaked with an error rather than freed or waited on forever (a dead libusb event loop is the only way to get there).
Context and measurements: #417 body; src/UsbTransport.cpp comments at the sites.
- 主要語言
- C
- 星號
- 56
- 分支
- 29
- 平均合併
- 3 小時 43 分鐘
- 30 天內合併 PR
- 75
環境準備
這個專案沒有提供開發容器、Dockerfile 或貢獻指南,環境需要你自己搭建:先看它的 README,通用步驟見我們的新手貢獻指南。
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
OpenIPC/devourer 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 82/100
維護者通常 1 天內回覆
-
Follow-ups left open by the 8822B fast bandwidth toggle fix (#584)可能已有人在做 @josephnef 今天認領。 未關閉enhancement
難度 4/5 3-5 天 新手友好度 42/100
維護者通常 1 天內回覆
-
難度 5/5 一週以上 新手友好度 12/100
OpenIPC/devourer#579 · 1 則留言 ·
維護者通常 1 天內回覆
-
enhancement
難度 5/5 一週以上 新手友好度 12/100
維護者通常 1 天內回覆
-
enhancement
難度 5/5 一週以上 新手友好度 8/100
維護者通常 1 天內回覆
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 72/100
維護者通常 1 天內回覆
-
Needs-Triage
難度 2/5 1-3 小時 新手友好度 66/100
維護者通常 2 天內回覆
-
issue: bug report
難度 2/5 1-3 小時 新手友好度 82/100
維護者通常 2 天內回覆
-
cross-platform fix-now
難度 2/5 1-3 小時 新手友好度 76/100
維護者通常 1 天內回覆
-
feature:index kind:crash status:confirmed triaged
難度 2/5 1-3 小時 新手友好度 77/100
維護者通常 1 天內回覆