Follow-ups left open by the pipelined bring-up writes (#417)

Aperta
#435 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
1-2 giorni
Idoneità per principianti
48/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
c
Ambito
backend

Direzione di ricerca

Read the comments at the relevant sites in src/UsbTransport.cpp and the context and measurements in issue #417. Trace async_write_cb and write_batch_begin, focusing on the completion/free-list handoff and the error-counter reset/generation ordering. Done means both identified pipelined-write races are addressed; the destructor behavior is explicitly a design decision, not a follow-up.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement

Two Qodo threads on #417 were closed without a change when the review cycle was stopped (maintainer decision; merged under skip-qodo-gate). Both are corner cases of the pipelined-write failure paths in UsbTransport, reachable only with two adapters sharing one libusb context in one process, which no demo does today.

  1. Completion counter published before the free-list handoff. async_write_cb increments pool->completed before the mutex-guarded free-list push. A taker on the batch thread that wakes on the counter can find the free list still empty and wait out one more turn. Cost is latency, not correctness. Fix shape: increment completed inside the same critical section as the push, or wake on the free list instead of the counter.

  2. write_errors reset before the generation bump. write_batch_begin clears write_errors and then increments generation. A late callback from a slot of the previous generation that runs between the two stores still compares equal to the old generation and can count into the fresh batch. Fix shape: bump the generation first, then reset the counter.

Also recorded as a deliberate design decision, not a follow-up: a pipelined transfer still submitted after the destructor's cancel + bounded reap is leaked with an error rather than freed or waited on forever (a dead libusb event loop is the only way to get there).

Context and measurements: #417 body; src/UsbTransport.cpp comments at the sites.

Lingua principale
C
Stelle
56
Fork
29
Merge medio
3h 43m
PR unite (30g)
75

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di OpenIPC/devourer

Tutte le issue di OpenIPC/devourer

Issue simili

Altre issue su C

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.