Follow-ups left open by the pipelined bring-up writes (#417)

未关闭
#435 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
1-2 天
新手友好度
48/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
c
领域
backend

调研方向

Read the comments at the relevant sites in src/UsbTransport.cpp and the context and measurements in issue #417. Trace async_write_cb and write_batch_begin, focusing on the completion/free-list handoff and the error-counter reset/generation ordering. Done means both identified pipelined-write races are addressed; the destructor behavior is explicitly a design decision, not a follow-up.

由索引模型根据 Issue 内容生成。

描述

enhancement

Two Qodo threads on #417 were closed without a change when the review cycle was stopped (maintainer decision; merged under skip-qodo-gate). Both are corner cases of the pipelined-write failure paths in UsbTransport, reachable only with two adapters sharing one libusb context in one process, which no demo does today.

  1. Completion counter published before the free-list handoff. async_write_cb increments pool->completed before the mutex-guarded free-list push. A taker on the batch thread that wakes on the counter can find the free list still empty and wait out one more turn. Cost is latency, not correctness. Fix shape: increment completed inside the same critical section as the push, or wake on the free list instead of the counter.

  2. write_errors reset before the generation bump. write_batch_begin clears write_errors and then increments generation. A late callback from a slot of the previous generation that runs between the two stores still compares equal to the old generation and can count into the fresh batch. Fix shape: bump the generation first, then reset the counter.

Also recorded as a deliberate design decision, not a follow-up: a pipelined transfer still submitted after the destructor's cancel + bounded reap is leaked with an error rather than freed or waited on forever (a dead libusb event loop is the only way to get there).

Context and measurements: #417 body; src/UsbTransport.cpp comments at the sites.

主要语言
C
星标
56
派生
29
平均合并
3 小时 43 分钟
30 天内合并 PR
75

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

OpenIPC/devourer 的其他 Issue

查看 OpenIPC/devourer 的全部 Issue

相似的 Issue

更多 C Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。