Series limit isn't applied in SQL for metric charts: every series is fetched, then capped in the browser

未關閉
#3,502 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
48/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
clickhouse, typescript

研究方向

Start by reading renderChartConfig.ts around renderSeriesLimitCte and the metric CTE construction, then compare with the client-side cap in ChartUtils.tsx. Reproduce the issue with an integration test in the style of renderChartConfig.int.test.ts using gauge, sum, and histogram metrics. Done when metric queries return only the requested top N series from SQL, as log and trace queries do.

由索引模型根據 Issue 內容生成。

描述

external

What happened?

With seriesLimit: 2 and a group-by over 5 hosts, on main (2bfc630):

Source Groups the SQL returns
logs (control) 2
gauge metric (avg) 5
sum metric (sum) 5
histogram metric (count) 5

renderSeriesLimitCte skips metric sources ("Skip CTE/metric sources (no real table to re-scan)"):

The app relies on that CTE, and otherwise caps the series client-side:

So a top-N metric chart on a high-cardinality attribute reads, aggregates and transfers every series, then the browser draws N of them. On our deployment:

  • a top-20 chart over a histogram with ~280 groups read 76 GB;
  • a top-10 chart over a sum with ~2,700 groups hit our 8 GiB per-query memory limit.

Expected: metric charts return the top N series from SQL, as log and trace charts do. The ranking could run on the per-series values after the metric CTEs, before the final pivot.

Related: #3204 (how the top N is picked across chunks).

Steps to reproduce

Reproduces on play.hyperdx.io? Didn't try.

An integration test in the style of renderChartConfig.int.test.ts, on main:

  1. Insert a gauge, a cumulative sum and a cumulative histogram repro.many for hosts h1–h5 (ResourceAttributes['host']).
  2. renderChartConfig with groupBy: "ResourceAttributes['host']", seriesLimit: 2, granularity: '5 minute', and one select of each metric type in turn.
  3. Each query returns all 5 hosts. The same config on a log source with groupBy: 'ServiceName' returns 2.

How are you running HyperDX?

Helm (ClickStack chart 2.1.0) with the hyperdx:2-nightly image (2.42.0 plus the Node bump from #3456), our own ClickHouse 26.2.5.45. Reproduced on main 2bfc630.

Where does it show up?

Dashboard time charts on metric sources with "Top N series"; we saw the cost through the MCP tools and in system.query_log.

Debug info

N/A.

Logs

None.


Written with help from an AI assistant (Claude Code). The behaviour comes from our own deployment and an integration test on main.

主要語言
TypeScript
星號
10.1k
分支
527
平均合併
1 天 20 小時
30 天內合併 PR
186

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

ClickHouse/ClickStack 的其他 Issue

查看 ClickHouse/ClickStack 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。