count_distinct aggFn on metric tiles ignores valueExpression, always counts distinct metric Values
維護者通常 1 天內回覆
評估
- 難度
- 2/5
- 預估耗時
- 1-3 小時
- 新手友好度
- 72/100
- Issue 類型
- 缺陷
- 描述清晰度
- 描述清楚
- 活躍度
- 冷清
- 技術堆疊
- clickhouse, sql, typescript
研究方向
從 packages/common-utils/src/core/renderChartConfig.ts 中的 translateMetricChartConfig 開始,檢查在產生 SQL 前如何翻譯 gauge 選取項目。重現 issue 中的 count_distinct 指標設定,保留其屬性的 valueExpression,並驗證產生的查詢計算的是相異的屬性值,而不是 LastValue。
由索引模型根據 Issue 內容生成。
描述
Bug Description
When using count_distinct as the aggFn on a metric tile, the valueExpression is ignored. The generated SQL always counts distinct values of the metric's float Value column rather than the specified attribute expression.
Steps to Reproduce
- Create a dashboard tile with
displayType: "number"and a metric select usingcount_distinctwith avalueExpressionpointing to an attribute:{ "displayType": "number", "source": "Metrics", "select": [ { "aggFn": "count_distinct", "valueExpression": "Attributes['name']", "metricName": "argocd_app_info", "metricType": "gauge" } ] } - Observe the number displayed — for an info metric (where
Valueis always1.0), the tile shows1or2instead of the actual count of distinct attribute values.
Expected Behavior
The tile should display the count of distinct values of Attributes['name'] across all time series for the metric — i.e., the number of distinct applications reported by argocd_app_info.
Direct ClickHouse query gives the correct answer:
SELECT uniqExact(Attributes['name'])
FROM default.otel_metrics_gauge
WHERE MetricName = 'argocd_app_info'
AND TimeUnix >= now() - INTERVAL 1 HOUR
-- returns 53
Actual Behavior
The generated SQL uses count(DISTINCT LastValue) where LastValue = last_value(Value) — the gauge's numeric value — not the attribute expression:
-- Generated by HyperDX
...
Bucketed AS (
SELECT
...,
last_value(Value) AS LastValue, -- <-- always the float metric value
any(Attributes) AS Attributes
FROM Source
GROUP BY AttributesHash, __hdx_time_bucket2
)
SELECT count(DISTINCT LastValue) -- <-- counts distinct 1.0, 0.0, etc.
FROM Bucketed
Result: 2 (distinct float values) instead of 53 (distinct app names).
Root Cause
In packages/common-utils/src/core/renderChartConfig.ts, translateMetricChartConfig unconditionally overwrites valueExpression with 'LastValue' for gauge metrics before passing the select config to SQL generation:
select: [
{
..._select,
valueExpression: 'LastValue', // overwrites user-provided Attributes['name']
aggCondition: '',
},
]
The original valueExpression from the user config is never used in metric query translation.
Additional Context
- The zod schema (
externalDashboardSelectItemSchemainpackages/api/src/utils/zod.ts) accepts and even requiresvalueExpressionfor non-countaggFns on metrics — so the intent to support this exists, but the query translator doesn't honour it. - The UI currently has no input for
valueExpressionon metric tiles, which makes sense given it's ignored — but fixing the translator would enable useful aggregations like counting distinct label values. - Confirmed present in v2.27.0. No prior issue or fix found.
Suggested Fix
For count_distinct (and potentially other aggFns where valueExpression refers to an attribute), use the user-provided expression instead of hardcoding 'LastValue':
// In translateMetricChartConfig for gauge metrics:
const effectiveValueExpression =
_select.aggFn === 'count_distinct' && _select.valueExpression
? _select.valueExpression
: 'LastValue';
select: [
{
..._select,
valueExpression: effectiveValueExpression,
aggCondition: '',
},
]
- 主要語言
- TypeScript
- 星號
- 10.1k
- 分支
- 527
- 平均合併
- 1 天 20 小時
- 30 天內合併 PR
- 186
環境準備
- 提供 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
ClickHouse/ClickStack 的其他 Issue
-
external
難度 2/5 1-3 小時 新手友好度 72/100
ClickHouse/ClickStack#3761 ·
維護者通常 1 天內回覆
-
Metric chart with aggFn increase and a multi-column group-by fails: toString() gets several arguments可能已有人在做 @CG-5228 於 26 天前認領。 未關閉external
難度 2/5 1-3 小時 新手友好度 76/100
ClickHouse/ClickStack#3477 · 1 則留言 ·
維護者通常 1 天內回覆
-
Slack notifications for inline alerts fail when the chart-explorer link passes Slack's 3000-character block limit可能已有人在做 @Tyagiquamar 於 27 天前認領。 未關閉alerting bug external
難度 2/5 1-3 小時 新手友好度 76/100
ClickHouse/ClickStack#3452 ·
維護者通常 1 天內回覆
-
check-alerts worker: 13 error spans (mongodb.create, NamespaceExists) every minute because mongoose autoCreate is still on可能重新可做 關聯的 PR 已關閉且未合併。 未關閉bug external Needs Feedback
難度 2/5 1-3 小時 新手友好度 72/100
ClickHouse/ClickStack#3308 · 1 則留言 ·
維護者通常 1 天內回覆
-
enhancement Needs Feedback
難度 5/5 一週以上 新手友好度 25/100
ClickHouse/ClickStack#3687 ·
維護者通常 1 天內回覆
查看 ClickHouse/ClickStack 的全部 Issue
相似的 Issue
-
Add: GTrekker未關閉check:passed streams:add
難度 1/5 1 小時以內 新手友好度 72/100
維護者通常 1 天內回覆
-
area: ui Bug Payload OSS
難度 1/5 1 小時以內 新手友好度 88/100
payloadcms/payload#19839 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 85/100
維護者通常 1 天內回覆
-
fix(auth): add the email OTP verification step to Pollar login可能已有人在做 @akansnoro 今天認領。 未關閉Stellar Wave
難度 2/5 1-3 小時 新手友好度 74/100
safetrustcr/dApp-SafeTrust#584 · 10 則留言 ·
維護者通常 1 天內回覆
-
The manager preset saves launch definitions without the required file and digest pair可能已有人在做 關聯的 PR 仍在進行中或已合併。 未關閉bug
難度 2/5 1-3 小時 新手友好度 80/100
維護者通常 1 天內回覆