Series limit isn't applied in SQL for metric charts: every series is fetched, then capped in the browser

Offen
#3,502 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
48/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
clickhouse, typescript

Rechercherichtung

Start by reading renderChartConfig.ts around renderSeriesLimitCte and the metric CTE construction, then compare with the client-side cap in ChartUtils.tsx. Reproduce the issue with an integration test in the style of renderChartConfig.int.test.ts using gauge, sum, and histogram metrics. Done when metric queries return only the requested top N series from SQL, as log and trace queries do.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

external

What happened?

With seriesLimit: 2 and a group-by over 5 hosts, on main (2bfc630):

Source Groups the SQL returns
logs (control) 2
gauge metric (avg) 5
sum metric (sum) 5
histogram metric (count) 5

renderSeriesLimitCte skips metric sources ("Skip CTE/metric sources (no real table to re-scan)"):

The app relies on that CTE, and otherwise caps the series client-side:

So a top-N metric chart on a high-cardinality attribute reads, aggregates and transfers every series, then the browser draws N of them. On our deployment:

  • a top-20 chart over a histogram with ~280 groups read 76 GB;
  • a top-10 chart over a sum with ~2,700 groups hit our 8 GiB per-query memory limit.

Expected: metric charts return the top N series from SQL, as log and trace charts do. The ranking could run on the per-series values after the metric CTEs, before the final pivot.

Related: #3204 (how the top N is picked across chunks).

Steps to reproduce

Reproduces on play.hyperdx.io? Didn't try.

An integration test in the style of renderChartConfig.int.test.ts, on main:

  1. Insert a gauge, a cumulative sum and a cumulative histogram repro.many for hosts h1–h5 (ResourceAttributes['host']).
  2. renderChartConfig with groupBy: "ResourceAttributes['host']", seriesLimit: 2, granularity: '5 minute', and one select of each metric type in turn.
  3. Each query returns all 5 hosts. The same config on a log source with groupBy: 'ServiceName' returns 2.

How are you running HyperDX?

Helm (ClickStack chart 2.1.0) with the hyperdx:2-nightly image (2.42.0 plus the Node bump from #3456), our own ClickHouse 26.2.5.45. Reproduced on main 2bfc630.

Where does it show up?

Dashboard time charts on metric sources with "Top N series"; we saw the cost through the MCP tools and in system.query_log.

Debug info

N/A.

Logs

None.


Written with help from an AI assistant (Claude Code). The behaviour comes from our own deployment and an integration test on main.

Vorherrschende Sprache
TypeScript
Sterne
10.1k
Forks
527
Ø Merge
1 T. 20 Std.
Gemergte PRs (30 T.)
186

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus ClickHouse/ClickStack

Alle Issues in ClickHouse/ClickStack

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.