Metric chart with aggFn increase and a multi-column group-by fails: toString() gets several arguments

未關閉 適合新手
#3,477 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

@CG-5228 已經在處理了。

開始於 2026年10月26日。

  • #3478 來自 @CG-5228 —— 未關閉

評估

難度
2/5
預估耗時
1-3 小時
新手友好度
76/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
clickhouse, typescript

研究方向

從 packages/common-utils/src/core/renderChartConfig.ts 開始,尤其檢視 issue 中描述的 increase group-by 篩選路徑,並將其與 series-limit CTE 對逗號分隔 group-by 欄位的處理方式進行比較。檢查附近關於 increase 搭配分組指標的測試,並補上兩個以逗號分隔字串提供的欄位之測試涵蓋。完成標準是查詢接受多欄位 group-by,並為每組欄位配對回傳一個 series。

由索引模型根據 Issue 內容生成。

描述

external

What happened?

A metric chart on a Sum metric with aggFn: increase and a group-by of two or more columns, given as a comma-separated string, fails with:

An incorrect number of arguments was specified for function 'toString'. Expected 1 argument, got 2 arguments: In scope SELECT tuple(Attributes['destination_service_name'], Attributes['response_code']) AS group, sum(Rate) AS bucket_value FROM Bucketed WHERE (Attributes['destination_service_name'], ((Attributes['response_code']) IS NOT NULL) AND (toString(Attributes['destination_service_name'], Attributes['response_code']) != '')) GROUP BY group, __hdx_time_bucket2.

Expected: one series per (destination_service_name, response_code) pair, the same as with a single group-by column.

What we checked on the same metric and time range:

  • increase with one group-by column works.
  • sum with the same two-column group-by works.
  • increase with two columns fails both with Map expressions (Attributes['a'], Attributes['b']) and with plain MATERIALIZED columns (`col_a`, `col_b`).

As far as we can tell, the cause is in the top-N ranking added for increase + group-by (packages/common-utils/src/core/renderChartConfig.ts at 7752c88):

Splitting the string group-by the same way before building groupByEmptyFilter should fix it. The tuple(${groupBySql}) parts already work with the comma-separated form.

Steps to reproduce

Reproduces on play.hyperdx.io? Didn't try. We hit it through the MCP tools on our own deployment.

  1. Use a Metric source whose sum table has a counter with two attributes, for example Istio's istio_requests_total (destination_service_name, response_code).
  2. Call the MCP tool clickstack_table with:
    • select: [{"aggFn": "increase", "metricType": "sum", "metricName": "istio_requests_total"}]
    • groupBy: "Attributes['destination_service_name'], Attributes['response_code']"
  3. It fails with the error above.
  4. Change aggFn to sum, or drop the second group-by column. It works.

We haven't checked the UI chart editor. It renders through the same renderChartConfig, so we expect a two-column group-by on an increase chart to fail the same way there.

How are you running HyperDX?

Helm (ClickStack chart 2.1.0) with the hyperdx:2-nightly image, which is 2.42.0 plus the Node bump from #3456. Our own ClickHouse 26.2.5.45.

Where does it show up?

The API: the MCP tool clickstack_table.

Debug info

N/A. We saw this through the API's MCP tools, not the UI.

Logs

The error is quoted above.


Written with help from an AI assistant (Claude Code). The behaviour and the error come from our own deployment.

主要語言
TypeScript
星號
10.1k
分支
527
平均合併
1 天 20 小時
30 天內合併 PR
186

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

ClickHouse/ClickStack 的其他 Issue

查看 ClickHouse/ClickStack 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。