Filter key and value limits are unordered and not configurable — fields and values silently disappear
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 68/100
- Issue 類型
- 缺陷
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- clickhouse, react, typescript
研究方向
從 packages/common-utils/src/core/metadata.ts 開始,追蹤 getAllFields、getMapKeys、getAllKeyValues、getKeyValues,以及 getMetricNames 的截斷模式。接著檢查 packages/app/src/hooks/useMetadata.tsx、TeamQueryConfigSection.tsx 和 DBSearchPageFilters/hooks.ts,了解設定流程和篩選器渲染。可設定的限制能傳遞到 discovery 和值、截斷結果具備確定性,並顯示在 UI 中,即表示完成。
由索引模型根據 Issue 內容生成。
描述
Field discovery and value autocomplete both truncate to a fixed number of results with no ORDER BY. On a high-cardinality source the survivors are an arbitrary subset, the UI gives no sign anything was dropped, and the one team setting that looks like it controls this doesn't reach either path.
We hit this on a source with ~6,150 distinct LogAttributes keys. Roughly 5,150 of them are invisible in the filter sidebar and there is no way to raise the ceiling.
Keys: capped at 1000, and Filter Keys Fetch Limit doesn't apply
getAllFields calls getMapKeys without maxKeys, so DEFAULT_MAX_KEYS = 1000 always wins:
metadata.ts:1536— the call, nomaxKeysargumentmetadata.ts:57—const DEFAULT_MAX_KEYS = 1000;metadata.ts:693—maxKeys = DEFAULT_MAX_KEYS
The team setting exists (TeamQueryConfigSection.tsx:320, "Filter Keys Fetch Limit") but is only read in useMultipleGetKeyValues, where it slices the already-truncated key array: useMetadata.tsx:372-373, applied at useMetadata.tsx:411. Raising it above 1000 changes nothing; lowering it below 1000 only trims what discovery already returned. Confirmed on the wire — discovery queries carry LIMIT 1000 regardless of the setting.
Keys: the text-index path has no ORDER BY
getMapKeys returns from the first non-empty path of four. On ClickHouse 26.4 with a text index on mapKeys(LogAttributes), the text-index path wins and the KV rollup is never consulted:
metadata.ts:754-759—SELECT token AS key … GROUP BY key HAVING key != '' LIMIT maxKeys, noORDER BYmetadata.ts:788-793— same for the kv-token index
Compare the rollup path, which does order by frequency: metadata.ts:846-853 — ORDER BY sum(count) DESC. Adding a text index therefore makes field discovery worse: you trade a frequency-ranked list for an arbitrary one.
Values: capped at a hardcoded 20, also unordered
metadata.ts:2267—getAllKeyValues({ maxValuesPerKey = 20 })metadata.ts:2494—getKeyValues({ limit = 20 })metadata.ts:2779—getKeyValuesWithMVs({ limit = 20 })useMetadata.tsx:412—maxValuesPerKey: 20, hardcodedDBSearchPageFilters/hooks.ts:33—INITIAL_LOAD_LIMIT = 20, passed at line 197
The SQL is groupUniqArray(limit)(…) throughout, with no ordering: 2570-2571, 2605, 1428, 1257, 1334.
"Load More" raises one key to 10,000 (hooks.ts:36), but it's a manual per-key click. The initial 20 that decides whether the value you're looking for is on screen at all has no setting behind it.
This is already documented in the codebase
metadata.ts:2652-2669 explains why getMetricNames avoids getKeyValues:
groupUniqArray(limit)(MetricName)"keeps an arbitrary subset once a table has more thanlimitdistinct names — the survivors follow hash order, not name order, and shift as the data and part layout change. On a high-cardinality source (a full Prometheus scrape) that silently hid metrics such asup, with no way to search for what had been dropped."
And useMetadata.tsx:526 tells callers to "Prefer this over useGetKeyValues({ keys: ['MetricName'] }), which samples an arbitrary subset via groupUniqArray".
The fix applied there is exactly what's missing everywhere else: a deterministic ORDER BY, LIMIT limit + 1, and a truncated flag so the caller knows the list was cut. A truncated field already exists in the shared type at metadata.ts:77.
What we'd like
A cap is reasonable. Being unable to raise it, and not being told it applied, is not.
- Pass
maxKeysfromfilterKeysFetchLimitthroughgetAllFieldsintogetMapKeys, so the existing setting actually controls key discovery. - Add a team setting for max values per key, replacing the hardcoded
20inuseMetadata.tsx:412andINITIAL_LOAD_LIMIT. - Add
ORDER BYto the truncating queries — frequency for keys (as the rollup path already does), something deterministic for values — so the subset is at least stable and useful. - Surface truncation in the UI, reusing the
limit + 1/truncatedpattern fromgetMetricNames.
Environment
- HyperDX 2.37.0, ClickHouse Cloud 26.4
otel_logswithtextindexes onmapKeys(LogAttributes),mapKeys(ResourceAttributes),mapKeys(ScopeAttributes)- ~6,150 distinct
LogAttributeskeys per 15-minute window
- 主要語言
- TypeScript
- 星號
- 10.1k
- 分支
- 527
- 平均合併
- 1 天 20 小時
- 30 天內合併 PR
- 186
環境準備
- 提供 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
ClickHouse/ClickStack 的其他 Issue
-
external
難度 2/5 1-3 小時 新手友好度 72/100
ClickHouse/ClickStack#3761 ·
維護者通常 1 天內回覆
-
Metric chart with aggFn increase and a multi-column group-by fails: toString() gets several arguments可能已有人在做 @CG-5228 於 26 天前認領。 未關閉external
難度 2/5 1-3 小時 新手友好度 76/100
ClickHouse/ClickStack#3477 · 1 則留言 ·
維護者通常 1 天內回覆
-
Slack notifications for inline alerts fail when the chart-explorer link passes Slack's 3000-character block limit可能已有人在做 @Tyagiquamar 於 27 天前認領。 未關閉alerting bug external
難度 2/5 1-3 小時 新手友好度 76/100
ClickHouse/ClickStack#3452 ·
維護者通常 1 天內回覆
-
check-alerts worker: 13 error spans (mongodb.create, NamespaceExists) every minute because mongoose autoCreate is still on可能重新可做 關聯的 PR 已關閉且未合併。 未關閉bug external Needs Feedback
難度 2/5 1-3 小時 新手友好度 72/100
ClickHouse/ClickStack#3308 · 1 則留言 ·
維護者通常 1 天內回覆
-
count_distinct aggFn on metric tiles ignores valueExpression, always counts distinct metric Values可能已有人在做 @Harshul1484 於 54 天前認領。 未關閉
難度 2/5 1-3 小時 新手友好度 72/100
ClickHouse/ClickStack#2311 ·
維護者通常 1 天內回覆
查看 ClickHouse/ClickStack 的全部 Issue
相似的 Issue
-
Add: GTrekker未關閉check:passed streams:add
難度 1/5 1 小時以內 新手友好度 72/100
維護者通常 1 天內回覆
-
area: ui Bug Payload OSS
難度 1/5 1 小時以內 新手友好度 88/100
payloadcms/payload#19839 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 85/100
維護者通常 1 天內回覆
-
fix(auth): add the email OTP verification step to Pollar login可能已有人在做 @akansnoro 今天認領。 未關閉Stellar Wave
難度 2/5 1-3 小時 新手友好度 74/100
safetrustcr/dApp-SafeTrust#584 · 10 則留言 ·
維護者通常 1 天內回覆
-
The manager preset saves launch definitions without the required file and digest pair可能已有人在做 關聯的 PR 仍在進行中或已合併。 未關閉bug
難度 2/5 1-3 小時 新手友好度 80/100
維護者通常 1 天內回覆