Filter key and value limits are unordered and not configurable — fields and values silently disappear
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 68/100
- Tipo de issue
- Error
- Claridad
- Bien especificado
- Estado de actividad
- Activo
- Stack tecnológico
- clickhouse, react, typescript
- Área
- backend, databases, frontend, observability
Línea de trabajo
Comienza en packages/common-utils/src/core/metadata.ts, siguiendo getAllFields, getMapKeys, getAllKeyValues, getKeyValues y el patrón de truncamiento de getMetricNames. Después inspecciona packages/app/src/hooks/useMetadata.tsx, TeamQueryConfigSection.tsx y DBSearchPageFilters/hooks.ts para ver el flujo de configuración y la representación de los filtros. Se considera terminado cuando los límites configurables llegan a discovery y a los valores, los resultados truncados son deterministas y se muestran en la UI.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Field discovery and value autocomplete both truncate to a fixed number of results with no ORDER BY. On a high-cardinality source the survivors are an arbitrary subset, the UI gives no sign anything was dropped, and the one team setting that looks like it controls this doesn't reach either path.
We hit this on a source with ~6,150 distinct LogAttributes keys. Roughly 5,150 of them are invisible in the filter sidebar and there is no way to raise the ceiling.
Keys: capped at 1000, and Filter Keys Fetch Limit doesn't apply
getAllFields calls getMapKeys without maxKeys, so DEFAULT_MAX_KEYS = 1000 always wins:
metadata.ts:1536— the call, nomaxKeysargumentmetadata.ts:57—const DEFAULT_MAX_KEYS = 1000;metadata.ts:693—maxKeys = DEFAULT_MAX_KEYS
The team setting exists (TeamQueryConfigSection.tsx:320, "Filter Keys Fetch Limit") but is only read in useMultipleGetKeyValues, where it slices the already-truncated key array: useMetadata.tsx:372-373, applied at useMetadata.tsx:411. Raising it above 1000 changes nothing; lowering it below 1000 only trims what discovery already returned. Confirmed on the wire — discovery queries carry LIMIT 1000 regardless of the setting.
Keys: the text-index path has no ORDER BY
getMapKeys returns from the first non-empty path of four. On ClickHouse 26.4 with a text index on mapKeys(LogAttributes), the text-index path wins and the KV rollup is never consulted:
metadata.ts:754-759—SELECT token AS key … GROUP BY key HAVING key != '' LIMIT maxKeys, noORDER BYmetadata.ts:788-793— same for the kv-token index
Compare the rollup path, which does order by frequency: metadata.ts:846-853 — ORDER BY sum(count) DESC. Adding a text index therefore makes field discovery worse: you trade a frequency-ranked list for an arbitrary one.
Values: capped at a hardcoded 20, also unordered
metadata.ts:2267—getAllKeyValues({ maxValuesPerKey = 20 })metadata.ts:2494—getKeyValues({ limit = 20 })metadata.ts:2779—getKeyValuesWithMVs({ limit = 20 })useMetadata.tsx:412—maxValuesPerKey: 20, hardcodedDBSearchPageFilters/hooks.ts:33—INITIAL_LOAD_LIMIT = 20, passed at line 197
The SQL is groupUniqArray(limit)(…) throughout, with no ordering: 2570-2571, 2605, 1428, 1257, 1334.
"Load More" raises one key to 10,000 (hooks.ts:36), but it's a manual per-key click. The initial 20 that decides whether the value you're looking for is on screen at all has no setting behind it.
This is already documented in the codebase
metadata.ts:2652-2669 explains why getMetricNames avoids getKeyValues:
groupUniqArray(limit)(MetricName)"keeps an arbitrary subset once a table has more thanlimitdistinct names — the survivors follow hash order, not name order, and shift as the data and part layout change. On a high-cardinality source (a full Prometheus scrape) that silently hid metrics such asup, with no way to search for what had been dropped."
And useMetadata.tsx:526 tells callers to "Prefer this over useGetKeyValues({ keys: ['MetricName'] }), which samples an arbitrary subset via groupUniqArray".
The fix applied there is exactly what's missing everywhere else: a deterministic ORDER BY, LIMIT limit + 1, and a truncated flag so the caller knows the list was cut. A truncated field already exists in the shared type at metadata.ts:77.
What we'd like
A cap is reasonable. Being unable to raise it, and not being told it applied, is not.
- Pass
maxKeysfromfilterKeysFetchLimitthroughgetAllFieldsintogetMapKeys, so the existing setting actually controls key discovery. - Add a team setting for max values per key, replacing the hardcoded
20inuseMetadata.tsx:412andINITIAL_LOAD_LIMIT. - Add
ORDER BYto the truncating queries — frequency for keys (as the rollup path already does), something deterministic for values — so the subset is at least stable and useful. - Surface truncation in the UI, reusing the
limit + 1/truncatedpattern fromgetMetricNames.
Environment
- HyperDX 2.37.0, ClickHouse Cloud 26.4
otel_logswithtextindexes onmapKeys(LogAttributes),mapKeys(ResourceAttributes),mapKeys(ScopeAttributes)- ~6,150 distinct
LogAttributeskeys per 15-minute window
- Lenguaje dominante
- TypeScript
- Estrellas
- 10.1k
- Forks
- 527
- Merge medio
- 1 d 20 h
- PR fusionados (30 d)
- 186
Preparar el entorno
- Incluye un Dockerfile o un archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de ClickHouse/ClickStack
-
external
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
ClickHouse/ClickStack#3761 ·
Los mantenedores suelen responder en 1 día
-
Metric chart with aggFn increase and a multi-column group-by fails: toString() gets several argumentsPosiblemente ocupada @CG-5228 la tomó hace 26 días. Abiertoexternal
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
ClickHouse/ClickStack#3477 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
Slack notifications for inline alerts fail when the chart-explorer link passes Slack's 3000-character block limitPosiblemente ocupada @Tyagiquamar la tomó hace 27 días. Abiertoalerting bug external
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
ClickHouse/ClickStack#3452 ·
Los mantenedores suelen responder en 1 día
-
check-alerts worker: 13 error spans (mongodb.create, NamespaceExists) every minute because mongoose autoCreate is still onQuizá libre de nuevo Un pull request para esta issue se cerró sin fusionarse. Abiertobug external Needs Feedback
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
ClickHouse/ClickStack#3308 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
count_distinct aggFn on metric tiles ignores valueExpression, always counts distinct metric ValuesPosiblemente ocupada @Harshul1484 la tomó hace 54 días. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
ClickHouse/ClickStack#2311 ·
Los mantenedores suelen responder en 1 día
Todos los issues de ClickHouse/ClickStack
Issues similares
-
Add: GTrekkerAbiertocheck:passed streams:add
Dificultad 1/5 Menos de una hora Aptitud para principiantes 72/100
Los mantenedores suelen responder en 1 día
-
area: ui Bug Payload OSS
Dificultad 1/5 Menos de una hora Aptitud para principiantes 88/100
payloadcms/payload#19839 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 85/100
Los mantenedores suelen responder en 1 día
-
fix(auth): add the email OTP verification step to Pollar loginPosiblemente ocupada @akansnoro la tomó hoy. AbiertoStellar Wave
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
safetrustcr/dApp-SafeTrust#584 · 10 comentarios ·
Los mantenedores suelen responder en 1 día
-
The manager preset saves launch definitions without the required file and digest pairPosiblemente ocupada Un pull request vinculado a esta issue está abierto o ya se fusionó. Abiertobug
Dificultad 2/5 1-3 horas Aptitud para principiantes 80/100
Los mantenedores suelen responder en 1 día