The Makefile runs python at parse time for every target
Maintainers usually reply within 1 day
A pull request for this has already been merged.
- #1298 by @isaaclimmy — merged
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 88/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- python
- Domain
- build-system
Research direction
Read Makefile at the XDIST and XDIST_ENV definitions. Change the variable evaluation so Python runs only for targets that use it, keeping both variables consistent. Done means make help starts no interpreter, verified with the failing-Python-on-PATH test described in the issue.
Written by the indexing model from the issue text.
Description
Where: Makefile (XDIST).
Current gap: XDIST := $(shell python3 -c ...) is evaluated whenever make reads the file, so even make help or make -n lint starts a Python interpreter just to decide whether pytest-xdist is installed.
Suggested approach: Use a lazily evaluated variable (=) so it is only expanded by the targets that use it, and keep XDIST_ENV consistent with it.
Done when: make help starts no interpreter, checked with a test that runs it with a failing python on PATH.
- Dominant language
- HTML
- Stars
- 47
- Forks
- 45
- Avg merge
- 2h 45m
- Merged PRs (30d)
- 93
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from yakew7/Fair-Code
-
check_contributors.py --stub always lists new people under Contributor tooling & docsPossibly taken @yangwenjie304 claimed this today. Opencommunity enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
yakew7/Fair-Code#1294 · 2 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
ci enhancement tooling
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
enhancement tooling
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
ci enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
enhancement good first issue tooling
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
All issues in yakew7/Fair-Code
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Frogging-Family/linux-tkg#1265 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 86/100
ziatdinovmax/SciLink#805 ·
Maintainers usually reply within 1 day
-
priority: low tests
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
TMHSDigital/Free-Game-Dev-Assets#265 ·
Maintainers usually reply within 1 day
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
cloudflare/vinext#4592 ·
Maintainers usually reply within 1 day