check_external_links.py main() assigns a module global for the retry delay
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 88/100
Research direction
Start with scripts/check_external_links.py, reading main, _open, and the run and check_url call paths. Trace how --retry-delay reaches the retry logic, then run the existing tests for this script. Done means calling main(['--retry-delay', '7']) leaves RETRY_DELAY unchanged and the tests no longer need to monkeypatch it.
Written by the indexing model from the issue text.
Description
Where: scripts/check_external_links.py (main, _open).
Current gap: --retry-delay is applied by assigning the module-level RETRY_DELAY inside main (with a global statement), so one in-process call changes the delay for every later call and the tests have to restore it by hand.
Suggested approach: Pass the delay down through run and check_url as a parameter with the constant as its default, and drop the global.
Done when: calling main(['--retry-delay', '7']) leaves RETRY_DELAY unchanged and the existing tests need no monkeypatch of it.
- Dominant language
- HTML
- Stars
- 47
- Forks
- 45
- Avg merge
- 2h 45m
- Merged PRs (30d)
- 93
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from yakew7/Fair-Code
-
check_contributors.py --stub always lists new people under Contributor tooling & docsPossibly taken @yangwenjie304 claimed this today. Opencommunity enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
yakew7/Fair-Code#1294 · 2 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
ci enhancement tooling
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
enhancement tooling
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
ci enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
community enhancement tooling
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
All issues in yakew7/Fair-Code
Similar issues
-
area:image bug
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
fix(docs): align git__gh troubleshooting with its actual failure pathsPossibly taken @akhil9tiet claimed this today. Openbug docs p2
Difficulty 1/5 1-3 hours Newbie friendliness 78/100
vercel/eve#6130 · 2 comments ·
Maintainers usually reply within 1 day
-
list_extensions description and empty result imply all extensions, but enumeration is unpacked-onlyOpen
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
ChromeDevTools/chrome-devtools-mcp#3425 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
zilliztech/memsearch#842 ·
Maintainers usually reply within 1 day