A make doctor failure blocks make check with no way to continue
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 76/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- python
- Domain
- build-system
Research direction
Start with the check target in Makefile and the exit behavior in scripts/check_environment.py; inspect how check invokes doctor. Add a warn mode that prints the existing report and lets make check continue, while the default still fails. Run make check DOCTOR=warn with a shadowing module and confirm it proceeds, then verify the default still exits with failure.
Written by the indexing model from the issue text.
Description
Where: Makefile (check), scripts/check_environment.py.
Current gap: check now depends on doctor (#1268) and the doctor exits 1 for any shadowing module, so on a machine with a harmless or unfixable one (this laptop has an old pathlib.py backport in site-packages) the whole of make check stops before lint.
Repro:
make doctor; echo $?
Suggested approach: Add make check DOCTOR=warn (or an --warn-only flag on the script) that prints the same report and exits 0, and say so in the failure message.
Done when: make check DOCTOR=warn proceeds past a shadowing module and the default still fails.
- Dominant language
- HTML
- Stars
- 47
- Forks
- 45
- Avg merge
- 2h 45m
- Merged PRs (30d)
- 93
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from yakew7/Fair-Code
-
check_contributors.py --stub always lists new people under Contributor tooling & docsPossibly taken @yangwenjie304 claimed this today. Opencommunity enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
yakew7/Fair-Code#1294 · 2 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
ci enhancement tooling
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
ci enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
enhancement good first issue tooling
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
community enhancement tooling
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
All issues in yakew7/Fair-Code
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Frogging-Family/linux-tkg#1265 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 86/100
ziatdinovmax/SciLink#805 ·
Maintainers usually reply within 1 day
-
priority: low tests
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
TMHSDigital/Free-Game-Dev-Assets#265 ·
Maintainers usually reply within 1 day
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
cloudflare/vinext#4592 ·
Maintainers usually reply within 1 day