make setup does not run make doctor at the end
Maintainers usually reply within 1 day
A pull request for this has already been merged.
- #1297 by @isaaclimmy — merged
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 88/100
Research direction
The issue points to the setup target in Makefile; read its recipe and the doctor target first. Check the target with make -n setup, then verify that a doctor failure does not make setup fail. Done when the dry run ends with the doctor step and its failure is non-fatal.
Written by the indexing model from the issue text.
Description
Where: Makefile (setup).
Current gap: make setup installs the dependencies and stops. The environment problem make doctor finds (a stdlib-shadowing module in site-packages) is only reported if the contributor runs it or make check.
Suggested approach: Run doctor as the last step of setup, printing its warning without failing the setup.
Done when: make -n setup ends with the doctor step and a doctor failure does not make setup fail.
- Dominant language
- HTML
- Stars
- 47
- Forks
- 45
- Avg merge
- 2h 45m
- Merged PRs (30d)
- 93
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from yakew7/Fair-Code
-
check_contributors.py --stub always lists new people under Contributor tooling & docsPossibly taken @yangwenjie304 claimed this today. Opencommunity enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
yakew7/Fair-Code#1294 · 2 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
ci enhancement tooling
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
enhancement tooling
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
ci enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
enhancement good first issue tooling
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
All issues in yakew7/Fair-Code
Similar issues
-
area:image bug
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
fix(docs): align git__gh troubleshooting with its actual failure pathsPossibly taken @akhil9tiet claimed this today. Openbug docs p2
Difficulty 1/5 1-3 hours Newbie friendliness 78/100
vercel/eve#6130 · 2 comments ·
Maintainers usually reply within 1 day
-
list_extensions description and empty result imply all extensions, but enumeration is unpacked-onlyOpen
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
ChromeDevTools/chrome-devtools-mcp#3425 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
zilliztech/memsearch#842 ·
Maintainers usually reply within 1 day