README: the green and red points are swapped (green = .fset tracking, red = .fset3 detection)
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 90/100
- Issue type
- Documentation
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- javascript
- Domain
- documentation
Research direction
Read the README’s “What you get” section and compare its color descriptions with the .fset and .fset3 behavior outlined in the issue. Update the wording wherever the demo text repeats the mix-up; done when it consistently describes .fset tracking points as green and .fset3 detection points as red.
Written by the indexing model from the issue text.
Description
The README says the demo draws the detection feature points as light green circles and the tracking points as small red circles ("What you get"). The code does the opposite:
.fsetis read withar2ReadSurfaceSet(path, "fset")(AR2 tracking data), becomesnftPoints, and is drawn light green (#34FF19, radius 10)..fset3is read withkpmLoadRefDataSet(path, "fset3")(KPM detection data), becomesnftFsetPoints, and is drawn red (#FF0119, radius 4).
For the pinball marker the demo draws 165 green and 4850 red circles, matching the log lines "NFT number of feature points: 165" (.fset) and "num = 4850" (.fset3).
WebARKitLib agrees: ARToolKitNFTCore detects with KPM, then hands the pose to AR2 with ar2SetInitTrans, which tracks.
Suggested fix: swap the wording in the README ("What you get") and anywhere else the demo text says the same.
- Dominant language
- JavaScript
- Stars
- 8
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from webarkit/FeatureSET-Display
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
All issues in webarkit/FeatureSET-Display
Similar issues
-
documentation good first issue theming
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
feature
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
drevendev/PatchPitch#2 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 65/100
521xueweihan/HelloGitHub#4025 ·