[2f] Add TypeScript declarations, JSDoc, and fix nftMarkerCount/markerNFTCount naming
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 35/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- javascript, typescript
- Domain
- api, developer-experience
Research direction
Start by inventorying the public methods in src/ARFset.js and related source files, then inspect examples for uses of nftMarkerCount and markerNFTCount. Done means the public API has TypeScript declarations, JSDoc with parameter and return information, and one consistent marker-count name throughout src/ and examples.
Written by the indexing model from the issue text.
Description
Summary
Add TypeScript declarations, JSDoc on all public methods, and resolve nftMarkerCount / markerNFTCount naming inconsistency
Environment
- Product/Service: FeatureSET-Display — JavaScript API
- Files:
src/ARFset.jsand related source files
Problem Description
Three related API-quality gaps:
- No type declarations: No
.d.tsfile exists, so TypeScript consumers get no type checking or IDE autocompletion. - No JSDoc: Public methods have no documentation, making the API opaque to new consumers.
- Naming inconsistency:
nftMarkerCount(field name) andmarkerNFTCount(local variable name) diverge — one of them is wrong, and the inconsistency is a footgun for callers.
Expected Behavior
- A
.d.tsdeclaration file (or TypeScript source) covers all public API surface. - Every public method has a JSDoc comment with parameter types, return type, and a one-line description.
nftMarkerCount/markerNFTCountare reconciled to a single consistent name throughout the codebase.
Actual Behavior
No type declarations, no JSDoc, inconsistent public naming.
Tasks
- Add TypeScript declarations (
.d.ts) — or convertsrc/to TypeScript outright - Add JSDoc on every public method
- Decide on naming:
nftMarkerCountvsmarkerNFTCountand rename consistently throughoutsrc/and any examples
Impact
Low — Developer experience and API usability. No runtime behavior change.
Additional Context
Converting src/ to TypeScript directly is the higher-value option (catches bugs at compile time, generates .d.ts automatically) but is a larger scope. Adding a hand-authored .d.ts is a quick win that unblocks TypeScript consumers immediately. The naming fix should happen regardless of which approach is chosen.
- Dominant language
- JavaScript
- Stars
- 8
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from webarkit/FeatureSET-Display
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 58/100
All issues in webarkit/FeatureSET-Display
Similar issues
-
Edit: RTE News LogoOpencheck:failed logos:edit
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
iptv-org/database#36354 · 1 comment ·
Maintainers usually reply within 4 days
-
agentic-workflows documentation workflow-editor
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
githubnext/gh-aw-workshop#4139 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
CircuitVerse/CircuitVerse#7967 · 1 comment · 1 reaction ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
CopilotKit/aimock#491 ·
Maintainers usually reply within 1 day
-
cvss-severity:high devguard l3montree-cybersecurity/.../devguard-documentation pkg:devguard/l3montree-c.../devguard-documentation risk:low state:open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
l3montree-dev/devguard-documentation#338 · 1 comment ·