weaviate/collections/classes/filters.py: an empty tuple passes equal() and five other filter builders, so the empty-list error only appears when the query runs

Đang mở Phù hợp với người mới
#2,265 0 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

Chưa có ai nhận issue này.

Đánh giá

Độ khó
2/5
Thời gian dự kiến
1-3 giờ
Mức phù hợp với người mới
84/100
Loại issue
Lỗi
Độ rõ ràng
Đặc tả rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
python

Hướng nghiên cứu

Đọc sáu bước kiểm tra xác thực trong weaviate/collections/classes/filters.py tại các dòng 225, 235, 245, 255, 269 và 283, sau đó so sánh các giá trị được chấp nhận với _to_value_list trong weaviate/collections/filters.py. Bổ sung kiểm thử cho thấy cả sáu builder đều từ chối () trong khi equal("") vẫn hợp lệ; hoàn tất khi lỗi được phát sinh lúc tạo bộ lọc và các kiểm thử unit tập trung đều đạt.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

bug

An empty tuple passes Filter.by_property(...).equal(()) and five sibling builders, while an empty list fails on the same call. The tuple's error appears only later, when a query converts the filter into its gRPC request.

Failure

_FilterByProperty.equal() builds the filter object a query later sends. It rejects an empty value only when isinstance(val, list) holds, so [] raises WeaviateInvalidInputError and () returns a filter. not_equal, less_than, less_or_equal, greater_than and greater_or_equal repeat the same check. FilterValuesList is typed as Sequence[...], so a type checker accepts the tuple.

One run on main at 200b57ea:

  1. A caller writes f = Filter.by_property("tags").equal(()). Nothing raises, and f holds the empty tuple.
  2. Later, collection.query.fetch_objects(filters=f) builds its request. It calls _FilterToGRPC.convert(filters) at weaviate/collections/grpc/query.py:517, which turns a filter object into its protobuf message.
  3. _FilterToGRPC.__value_filter converts any non-string sequence to a list with _to_value_list and finds it empty. It raises WeaviateInvalidInputError: Filtering on empty lists is not supported by Weaviate.

The caller sees the right message, but the traceback points at fetch_objects instead of the line that built the filter. With equal([]) the same message points at equal(). Code that builds filters in one module and runs queries in another has to trace the tuple back by hand.

Reachability

Reachable. Any caller of the public Filter.by_property(...) API can pass an empty tuple, and nothing between that call and equal() converts it.

Severity

Low. The message is correct and no request reaches the server. Only the point where the error is raised is wrong.

Location

weaviate/collections/classes/filters.py:225, with the same check at :235, :245, :255, :269 and :283.

https://github.com/weaviate/weaviate-python-client/blob/200b57ead17a9572f4779188af08f7318b445f76/weaviate/collections/classes/filters.py#L225

Excerpt
    def equal(self, val: FilterValues) -> _Filters:
        """Filter on whether the property is equal to the given value."""
        if isinstance(val, list) and len(val) == 0:
            raise WeaviateInvalidInputError(
                "Filtering on empty lists is not supported by Weaviate. "
                "To filter by property length, use "
                "Filter.by_property('prop', length=True).equal(0)"
            )
        return _FilterValue(target=self._target_path(), value=val, operator=_Operator.EQUAL)
Reproduction

No server is needed. The script calls _FilterToGRPC.convert, the same call fetch_objects makes at grpc/query.py:517.

from weaviate.classes.query import Filter
from weaviate.collections.filters import _FilterToGRPC
from weaviate.exceptions import WeaviateInvalidInputError

for name in ["equal", "not_equal", "less_than", "less_or_equal", "greater_than", "greater_or_equal"]:
    for val in ([], ()):
        try:
            getattr(Filter.by_property("tags"), name)(val)
            print(f"{name}({val!r}): builder accepted it")
        except WeaviateInvalidInputError:
            print(f"{name}({val!r}): builder raised WeaviateInvalidInputError")

f = Filter.by_property("tags").equal(())
try:
    _FilterToGRPC.convert(f)
except WeaviateInvalidInputError as e:
    print("convert raised WeaviateInvalidInputError:", e)

Run from the repository root with PYTHONPATH=. python repro.py on 200b57ea. It prints:

equal([]): builder raised WeaviateInvalidInputError
equal(()): builder accepted it
not_equal([]): builder raised WeaviateInvalidInputError
not_equal(()): builder accepted it
less_than([]): builder raised WeaviateInvalidInputError
less_than(()): builder accepted it
less_or_equal([]): builder raised WeaviateInvalidInputError
less_or_equal(()): builder accepted it
greater_than([]): builder raised WeaviateInvalidInputError
greater_than(()): builder accepted it
greater_or_equal([]): builder raised WeaviateInvalidInputError
greater_or_equal(()): builder accepted it
convert raised WeaviateInvalidInputError: Invalid input provided: Filtering on empty lists is not supported by Weaviate. To filter by property length, use Filter.by_property('prop', length=True).equal(0).
Suggested fix

In weaviate/collections/classes/filters.py, change the six checks to match any non-string sequence, the way _to_value_list in weaviate/collections/filters.py:23 does:

if isinstance(val, Sequence) and not isinstance(val, (str, bytes)) and len(val) == 0:

Keep the str and bytes exclusion, since equal("") is a valid filter on an empty string. A unit test asserting that each of the six methods raises WeaviateInvalidInputError for () confirms the fix. The six copies of the check could also become one helper.

Provenance

Pre-existing. The six checks come from 5cb7e1a9 (2026-02-12, "Fix empty list filter raising IndexError instead of WeaviateInvalidInputError"). #2169 (142d798a..200b57ea) changed only weaviate/collections/filters.py and its tests. Before #2169, the serializer also checked only for list, so the tuple reached the server as a filter with no value set. #2169 made the serializer reject it with the right message. Its description says it chose not to patch the builder methods. The closed #933 asked for this exception on empty lists.

Verification

Confirmed by the reproduction above on 200b57ea, which is on main since #2169 merged.

Where it surfaced

Review of #2169 (fix/filter-accepts-sequence-values, base main).

Ngôn ngữ chính
Python
Star
230
Fork
173
Merge trung bình
4 ngày 16 giờ
Pull request đã merge (30 ngày)
23

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của weaviate/weaviate-python-client

Tất cả issue của weaviate/weaviate-python-client

Issue tương tự

Thêm issue về Python

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.