weaviate/collections/classes/filters.py: an empty tuple passes equal() and five other filter builders, so the empty-list error only appears when the query runs
Mantenedores costumam responder em até 1 dia
Ninguém assumiu esta issue ainda.
Avaliação
- Dificuldade
- 2/5
- Tempo estimado
- 1-3 horas
- Facilidade para iniciantes
- 84/100
- Tipo de issue
- Bug
- Clareza
- Claramente especificada
- Status de atividade
- Ativa
- Stack de tecnologia
- python
- Domínio
- backend-api-design, testing
Direção de pesquisa
Leia as seis verificações de validação em weaviate/collections/classes/filters.py nas linhas 225, 235, 245, 255, 269 e 283 e, em seguida, compare os valores aceitos com _to_value_list em weaviate/collections/filters.py. Adicione testes mostrando que os seis builders rejeitam () enquanto equal("") continua válido; o trabalho estará concluído quando o erro for gerado na construção do filtro e os testes unitários específicos passarem.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
An empty tuple passes Filter.by_property(...).equal(()) and five sibling builders, while an empty list fails on the same call. The tuple's error appears only later, when a query converts the filter into its gRPC request.
Failure
_FilterByProperty.equal() builds the filter object a query later sends. It rejects an empty value only when isinstance(val, list) holds, so [] raises WeaviateInvalidInputError and () returns a filter. not_equal, less_than, less_or_equal, greater_than and greater_or_equal repeat the same check. FilterValuesList is typed as Sequence[...], so a type checker accepts the tuple.
One run on main at 200b57ea:
- A caller writes
f = Filter.by_property("tags").equal(()). Nothing raises, andfholds the empty tuple. - Later,
collection.query.fetch_objects(filters=f)builds its request. It calls_FilterToGRPC.convert(filters)atweaviate/collections/grpc/query.py:517, which turns a filter object into its protobuf message. _FilterToGRPC.__value_filterconverts any non-string sequence to a list with_to_value_listand finds it empty. It raisesWeaviateInvalidInputError: Filtering on empty lists is not supported by Weaviate.
The caller sees the right message, but the traceback points at fetch_objects instead of the line that built the filter. With equal([]) the same message points at equal(). Code that builds filters in one module and runs queries in another has to trace the tuple back by hand.
Reachability
Reachable. Any caller of the public Filter.by_property(...) API can pass an empty tuple, and nothing between that call and equal() converts it.
Severity
Low. The message is correct and no request reaches the server. Only the point where the error is raised is wrong.
Location
weaviate/collections/classes/filters.py:225, with the same check at :235, :245, :255, :269 and :283.
Excerpt
def equal(self, val: FilterValues) -> _Filters:
"""Filter on whether the property is equal to the given value."""
if isinstance(val, list) and len(val) == 0:
raise WeaviateInvalidInputError(
"Filtering on empty lists is not supported by Weaviate. "
"To filter by property length, use "
"Filter.by_property('prop', length=True).equal(0)"
)
return _FilterValue(target=self._target_path(), value=val, operator=_Operator.EQUAL)
Reproduction
No server is needed. The script calls _FilterToGRPC.convert, the same call fetch_objects makes at grpc/query.py:517.
from weaviate.classes.query import Filter
from weaviate.collections.filters import _FilterToGRPC
from weaviate.exceptions import WeaviateInvalidInputError
for name in ["equal", "not_equal", "less_than", "less_or_equal", "greater_than", "greater_or_equal"]:
for val in ([], ()):
try:
getattr(Filter.by_property("tags"), name)(val)
print(f"{name}({val!r}): builder accepted it")
except WeaviateInvalidInputError:
print(f"{name}({val!r}): builder raised WeaviateInvalidInputError")
f = Filter.by_property("tags").equal(())
try:
_FilterToGRPC.convert(f)
except WeaviateInvalidInputError as e:
print("convert raised WeaviateInvalidInputError:", e)
Run from the repository root with PYTHONPATH=. python repro.py on 200b57ea. It prints:
equal([]): builder raised WeaviateInvalidInputError
equal(()): builder accepted it
not_equal([]): builder raised WeaviateInvalidInputError
not_equal(()): builder accepted it
less_than([]): builder raised WeaviateInvalidInputError
less_than(()): builder accepted it
less_or_equal([]): builder raised WeaviateInvalidInputError
less_or_equal(()): builder accepted it
greater_than([]): builder raised WeaviateInvalidInputError
greater_than(()): builder accepted it
greater_or_equal([]): builder raised WeaviateInvalidInputError
greater_or_equal(()): builder accepted it
convert raised WeaviateInvalidInputError: Invalid input provided: Filtering on empty lists is not supported by Weaviate. To filter by property length, use Filter.by_property('prop', length=True).equal(0).
Suggested fix
In weaviate/collections/classes/filters.py, change the six checks to match any non-string sequence, the way _to_value_list in weaviate/collections/filters.py:23 does:
if isinstance(val, Sequence) and not isinstance(val, (str, bytes)) and len(val) == 0:
Keep the str and bytes exclusion, since equal("") is a valid filter on an empty string. A unit test asserting that each of the six methods raises WeaviateInvalidInputError for () confirms the fix. The six copies of the check could also become one helper.
Provenance
Pre-existing. The six checks come from 5cb7e1a9 (2026-02-12, "Fix empty list filter raising IndexError instead of WeaviateInvalidInputError"). #2169 (142d798a..200b57ea) changed only weaviate/collections/filters.py and its tests. Before #2169, the serializer also checked only for list, so the tuple reached the server as a filter with no value set. #2169 made the serializer reject it with the right message. Its description says it chose not to patch the builder methods. The closed #933 asked for this exception on empty lists.
Verification
Confirmed by the reproduction above on 200b57ea, which is on main since #2169 merged.
Where it surfaced
Review of #2169 (fix/filter-accepts-sequence-values, base main).
- Linguagem predominante
- Python
- Estrelas
- 230
- Forks
- 173
- Merge médio
- 4d 16h
- PRs com merge (30d)
- 23
Preparar o ambiente
- Sem Dockerfile nem arquivo Docker Compose
- Sem modelo de pull request
- Ler o guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de weaviate/weaviate-python-client
-
Batch: re-added rate-limited objects stay in results.objs.all_responses as errorsTalvez já em andamento Um pull request vinculado a esta issue está aberto ou já foi mesclado. Aberta
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 82/100
weaviate/weaviate-python-client#2179 ·
Mantenedores costumam responder em até 1 dia
-
collections/batch: one object that fails client-side encoding fails every object sent with itTalvez já em andamento @shadowmodder assumiu hoje. Abertabug
Dificuldade 3/5 1-2 dias Facilidade para iniciantes 72/100
weaviate/weaviate-python-client#2266 ·
Mantenedores costumam responder em até 1 dia
-
batch insert fails the whole batch with "ValueError: Unexpected type" when a value is a DecimalTalvez já em andamento @steven-asearcy assumiu hoje. Aberta
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 35/100
weaviate/weaviate-python-client#2263 ·
Mantenedores costumam responder em até 1 dia
-
collections/batch/sync.py: after a fast hang-up reconnect the old stream's sender steals a request, hanging add_objectTalvez já em andamento @shadowmodder assumiu há 2 dias. Abertabug
Dificuldade 4/5 3-5 dias Facilidade para iniciantes 45/100
weaviate/weaviate-python-client#2261 ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 4/5 3-5 dias Facilidade para iniciantes 48/100
weaviate/weaviate-python-client#2259 ·
Mantenedores costumam responder em até 1 dia
Todas as issues de weaviate/weaviate-python-client
Issues semelhantes
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 65/100
Deltares/numba_celltree#100 · 1 comentário ·
-
auto-reported bug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 63/100
Mantenedores costumam responder em até 1 dia
-
soup airgap-bundle --bundle-size-cap nan, inf or a cap above ~1.67e299 GiB stops with an internal ValueError/OverflowError (exit 1) instead of a usage errorTalvez já em andamento @Keshemir assumiu hoje. Abertabug claimed difficulty:2
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 82/100
MakazhanAlpamys/Soup#3045 · 2 comentários ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 76/100
dagster-io/skills#80 ·
-
bug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
Mantenedores costumam responder em até 1 dia