weaviate/collections/classes/filters.py: an empty tuple passes equal() and five other filter builders, so the empty-list error only appears when the query runs

未关闭 适合新手
#2,265 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
84/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
python

调研方向

阅读weaviate/collections/classes/filters.py第225、235、245、255、269和283行的六项验证检查,然后将其接受的值与weaviate/collections/filters.py中的_to_value_list进行比较。添加测试,证明六个 builder 都会拒绝(),而equal("")仍然有效;当错误在构造过滤器时抛出且针对性的单元测试通过时,任务即完成。

由索引模型根据 Issue 内容生成。

描述

bug

An empty tuple passes Filter.by_property(...).equal(()) and five sibling builders, while an empty list fails on the same call. The tuple's error appears only later, when a query converts the filter into its gRPC request.

Failure

_FilterByProperty.equal() builds the filter object a query later sends. It rejects an empty value only when isinstance(val, list) holds, so [] raises WeaviateInvalidInputError and () returns a filter. not_equal, less_than, less_or_equal, greater_than and greater_or_equal repeat the same check. FilterValuesList is typed as Sequence[...], so a type checker accepts the tuple.

One run on main at 200b57ea:

  1. A caller writes f = Filter.by_property("tags").equal(()). Nothing raises, and f holds the empty tuple.
  2. Later, collection.query.fetch_objects(filters=f) builds its request. It calls _FilterToGRPC.convert(filters) at weaviate/collections/grpc/query.py:517, which turns a filter object into its protobuf message.
  3. _FilterToGRPC.__value_filter converts any non-string sequence to a list with _to_value_list and finds it empty. It raises WeaviateInvalidInputError: Filtering on empty lists is not supported by Weaviate.

The caller sees the right message, but the traceback points at fetch_objects instead of the line that built the filter. With equal([]) the same message points at equal(). Code that builds filters in one module and runs queries in another has to trace the tuple back by hand.

Reachability

Reachable. Any caller of the public Filter.by_property(...) API can pass an empty tuple, and nothing between that call and equal() converts it.

Severity

Low. The message is correct and no request reaches the server. Only the point where the error is raised is wrong.

Location

weaviate/collections/classes/filters.py:225, with the same check at :235, :245, :255, :269 and :283.

https://github.com/weaviate/weaviate-python-client/blob/200b57ead17a9572f4779188af08f7318b445f76/weaviate/collections/classes/filters.py#L225

Excerpt
    def equal(self, val: FilterValues) -> _Filters:
        """Filter on whether the property is equal to the given value."""
        if isinstance(val, list) and len(val) == 0:
            raise WeaviateInvalidInputError(
                "Filtering on empty lists is not supported by Weaviate. "
                "To filter by property length, use "
                "Filter.by_property('prop', length=True).equal(0)"
            )
        return _FilterValue(target=self._target_path(), value=val, operator=_Operator.EQUAL)
Reproduction

No server is needed. The script calls _FilterToGRPC.convert, the same call fetch_objects makes at grpc/query.py:517.

from weaviate.classes.query import Filter
from weaviate.collections.filters import _FilterToGRPC
from weaviate.exceptions import WeaviateInvalidInputError

for name in ["equal", "not_equal", "less_than", "less_or_equal", "greater_than", "greater_or_equal"]:
    for val in ([], ()):
        try:
            getattr(Filter.by_property("tags"), name)(val)
            print(f"{name}({val!r}): builder accepted it")
        except WeaviateInvalidInputError:
            print(f"{name}({val!r}): builder raised WeaviateInvalidInputError")

f = Filter.by_property("tags").equal(())
try:
    _FilterToGRPC.convert(f)
except WeaviateInvalidInputError as e:
    print("convert raised WeaviateInvalidInputError:", e)

Run from the repository root with PYTHONPATH=. python repro.py on 200b57ea. It prints:

equal([]): builder raised WeaviateInvalidInputError
equal(()): builder accepted it
not_equal([]): builder raised WeaviateInvalidInputError
not_equal(()): builder accepted it
less_than([]): builder raised WeaviateInvalidInputError
less_than(()): builder accepted it
less_or_equal([]): builder raised WeaviateInvalidInputError
less_or_equal(()): builder accepted it
greater_than([]): builder raised WeaviateInvalidInputError
greater_than(()): builder accepted it
greater_or_equal([]): builder raised WeaviateInvalidInputError
greater_or_equal(()): builder accepted it
convert raised WeaviateInvalidInputError: Invalid input provided: Filtering on empty lists is not supported by Weaviate. To filter by property length, use Filter.by_property('prop', length=True).equal(0).
Suggested fix

In weaviate/collections/classes/filters.py, change the six checks to match any non-string sequence, the way _to_value_list in weaviate/collections/filters.py:23 does:

if isinstance(val, Sequence) and not isinstance(val, (str, bytes)) and len(val) == 0:

Keep the str and bytes exclusion, since equal("") is a valid filter on an empty string. A unit test asserting that each of the six methods raises WeaviateInvalidInputError for () confirms the fix. The six copies of the check could also become one helper.

Provenance

Pre-existing. The six checks come from 5cb7e1a9 (2026-02-12, "Fix empty list filter raising IndexError instead of WeaviateInvalidInputError"). #2169 (142d798a..200b57ea) changed only weaviate/collections/filters.py and its tests. Before #2169, the serializer also checked only for list, so the tuple reached the server as a filter with no value set. #2169 made the serializer reject it with the right message. Its description says it chose not to patch the builder methods. The closed #933 asked for this exception on empty lists.

Verification

Confirmed by the reproduction above on 200b57ea, which is on main since #2169 merged.

Where it surfaced

Review of #2169 (fix/filter-accepts-sequence-values, base main).

主要语言
Python
星标
230
派生
173
平均合并
4 天 16 小时
30 天内合并 PR
23

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

weaviate/weaviate-python-client 的其他 Issue

查看 weaviate/weaviate-python-client 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。