DLQ marks a request terminal error after its batch already handed off to land
Maintainers usually reply within 2 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 54/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- go
- Domain
- distributed-systems
Research direction
Start by tracing the speculate controller's batch outcome handoff and the DLQ reconciliation paths for land and landsignal; the payload does not name specific files or tests. Check how reconciliation determines whether a batch has handed its outcome to the land. Done means a request in that state is not marked terminal error by DLQ reconciliation, including the reachable land and landsignal cases.
Written by the indexing model from the issue text.
Description
Problem
A request can be reported as error after its change has already landed on the target branch.
Cause
The speculate controller decided a batch's outcome and published the land before its delivery finished. When something later in the same delivery failed, the message was rejected, and the DLQ reconciler marked the request terminal error without checking that the batch had already handed its outcome to the land. The merge then landed anyway.
Observed on a demo run: the land was published, the same delivery failed, the DLQ marked the request error, and the merge appeared on main three seconds later.
Expected
A request whose batch has handed its outcome to the land must not be moved to error by DLQ reconciliation.
Status
No fixing change has been identified on main. The same class is still reachable through the land and landsignal DLQs; see the companion issue linked from #819.
- Dominant language
- Go
- Stars
- 247
- Forks
- 16
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 125
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from uber/submitqueue
-
[Bug] Land returns codes.Unknown instead of InvalidArgument for an unrecognized strategyPossibly taken @DivyanshGarg380 claimed this 14 days ago. Openbug
Difficulty 1/5 Under an hour Newbie friendliness 22/100
uber/submitqueue#996 ·
Maintainers usually reply within 2 days
-
Batch-scoped DLQ reconciler fails requests that another live batch ownsPossibly taken @burgulvedant claimed this 14 days ago. Openbug
Difficulty 4/5 3-5 days Newbie friendliness 55/100
uber/submitqueue#826 · 1 comment ·
Maintainers usually reply within 2 days
-
Cancel misses a batch mid-promotion, letting a cancelled request reach speculationMay be free again @burgulvedant claimed this 14 days ago, and no pull request is open. Openbug
Difficulty 4/5 3-5 days Newbie friendliness 45/100
uber/submitqueue#825 · 1 comment ·
Maintainers usually reply within 2 days
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 52/100
uber/submitqueue#824 · 2 comments ·
Maintainers usually reply within 2 days
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 55/100
uber/submitqueue#820 ·
Maintainers usually reply within 2 days
All issues in uber/submitqueue
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
kubescape/node-agent#1099 ·
Maintainers usually reply within 1 day
-
import-export
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
genealogix/glx#1498 ·
Maintainers usually reply within 2 days
-
Docs: 2 broken linksOpenBug pulumi/pulumi-terraform-bridge R2 S2
Difficulty 1/5 Under an hour Newbie friendliness 72/100
pulumi/pulumi-terraform-bridge#3713 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ossf/pvtr-github-repo-scanner#539 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
goreleaser/goreleaser#7316 ·
Maintainers usually reply within 1 day