DLQ marks a request terminal error after its batch already handed off to land

Aperta
#818 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
54/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
go

Direzione di ricerca

Start by tracing the speculate controller's batch outcome handoff and the DLQ reconciliation paths for land and landsignal; the payload does not name specific files or tests. Check how reconciliation determines whether a batch has handed its outcome to the land. Done means a request in that state is not marked terminal error by DLQ reconciliation, including the reachable land and landsignal cases.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug

Problem

A request can be reported as error after its change has already landed on the target branch.

Cause

The speculate controller decided a batch's outcome and published the land before its delivery finished. When something later in the same delivery failed, the message was rejected, and the DLQ reconciler marked the request terminal error without checking that the batch had already handed its outcome to the land. The merge then landed anyway.

Observed on a demo run: the land was published, the same delivery failed, the DLQ marked the request error, and the merge appeared on main three seconds later.

Expected

A request whose batch has handed its outcome to the land must not be moved to error by DLQ reconciliation.

Status

No fixing change has been identified on main. The same class is still reachable through the land and landsignal DLQs; see the companion issue linked from #819.

Lingua principale
Go
Stelle
247
Fork
16
Merge medio
2g 1h
PR unite (30g)
125

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di uber/submitqueue

Tutte le issue di uber/submitqueue

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.