Correct the TTL expiration benchmark test link

Open Beginner friendly
#1,099 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
72/100
Issue type
Documentation
Clarity
Mostly clear
Activity status
Active
Tech stack
markdown
Domain
documentation

Research direction

The stale link is the Adapter behavior tests URL in benchmark/ttlcache-expiration.md, currently pinned to commit 349273dd. Find a later commit where TestSetReclaimsOneExpiredEntry and TestRenewalChangesExpirationOrder exist, for example with git log -S on those test names, and check that the link opens the test code. Done when the link points to a revision containing both tests and no other text in the file has changed.

Written by the indexing model from the issue text.

Description

The Adapter behavior tests link in benchmark/ttlcache-expiration.md points to commit 349273dd2e38fe8ff031595f1afce90478eb4ea6, which predates TestSetReclaimsOneExpiredEntry and TestRenewalChangesExpirationOrder. Update it to a revision containing those tests (raised by the existing CodeRabbit review on PR #1098).

Dominant language
Go
Stars
39
Forks
42
Avg merge
1d 18h
Merged PRs (30d)
40

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from kubescape/node-agent

All issues in kubescape/node-agent

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.