DLQ marks a request terminal error after its batch already handed off to land

Offen
  • Stimmt etwas nicht?
#818 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 2 Tagen

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
54/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
go
Bereich
distributed-systems

Rechercherichtung

Start by tracing the speculate controller's batch outcome handoff and the DLQ reconciliation paths for land and landsignal; the payload does not name specific files or tests. Check how reconciliation determines whether a batch has handed its outcome to the land. Done means a request in that state is not marked terminal error by DLQ reconciliation, including the reachable land and landsignal cases.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

bug

Problem

A request can be reported as error after its change has already landed on the target branch.

Cause

The speculate controller decided a batch's outcome and published the land before its delivery finished. When something later in the same delivery failed, the message was rejected, and the DLQ reconciler marked the request terminal error without checking that the batch had already handed its outcome to the land. The merge then landed anyway.

Observed on a demo run: the land was published, the same delivery failed, the DLQ marked the request error, and the merge appeared on main three seconds later.

Expected

A request whose batch has handed its outcome to the land must not be moved to error by DLQ reconciliation.

Status

No fixing change has been identified on main. The same class is still reachable through the land and landsignal DLQs; see the companion issue linked from #819.

Vorherrschende Sprache
Go
Sterne
247
Forks
16
Ø Merge
2 T. 1 Std.
Gemergte PRs (30 T.)
125

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus uber/submitqueue

Alle Issues in uber/submitqueue

Ähnliche Issues

Weitere Issues zu Go

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.