[Raidevents] Overlapping Adds event causes problems
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 20/100
Research direction
Compare the two linked Raidbots reports and their Pastebin inputs, focusing on the difference in add-event naming and overlap. Then trace how the project handles those events; the issue does not name files or tests, so first locate the relevant simulation code and a way to reproduce the DPS change. Done means the named overlapping adds no longer cause the reported drastic DPS drop.
Written by the indexing model from the issue text.
Description
Naming add events causing a simulation to drop drasticly in dps output.
with name: https://www.raidbots.com/simbot/report/5DHRyyTrPw6r3aJ9hSiYmo/simc
input: https://pastebin.com/raw/ySNep3Zv
without name: https://www.raidbots.com/simbot/report/ACKzLXXEcSHkf6DDCbuqz/simc
input: https://pastebin.com/raw/30ME30xw
- Dominant language
- C++
- Stars
- 1.6k
- Forks
- 789
- Avg merge
- 13h 25m
- Merged PRs (30d)
- 52
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from simulationcraft/simc
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
simulationcraft/simc#11973 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 69/100
simulationcraft/simc#11747 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
simulationcraft/simc#11935 ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
simulationcraft/simc#11918 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
simulationcraft/simc#11845 ·
Maintainers usually reply within 1 day
All issues in simulationcraft/simc
Similar issues
-
bug libcudf
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 2 days
-
level/task module/cloud monitoring type/maintenance
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
LadybirdBrowser/ladybird#13809 ·
Maintainers usually reply within 1 day
-
bug module:nodes tests
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
rocketride-org/rocketride-server#3020 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 9 days