fmt::formatted_size does not work with fmt::wformat_string
Maintainers usually reply within 9 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
Research direction
Start by reading the declaration and implementation of fmt::formatted_size and how detail::format_string_char_t<S> handles fmt::wformat_string. Add support for the wide format string overload and check the existing formatted_size tests for a place to cover it. Done when the wide string case compiles and reports the formatted output size.
Written by the indexing model from the issue text.
Description
I maintain a library at my work that supports both char and wchar strings. We use fmt::formatted_size to help us mange our memory allocations, but it does not work with fmt::wformat_string, requiring me to maintain a fork that adds this support.
The crux of the issue is that detail::format_string_char_t<S> does not provide a value when S is a fmt::wformat_string. Adding an overload of fmt::formatted_size that takes a fmt::wformat_string specifically resolves the issue. I unfortunately do not currently have legal approval to provide that patch upstream, so I am making this issue to raise the problem and hopefully someone will be able to contribute the necessary fix.
- Dominant language
- C++
- Stars
- 25.9k
- Forks
- 3.1k
- Avg merge
- 9d 5h
- Merged PRs (30d)
- 13
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from fmtlib/fmt
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
fmtlib/fmt#5006 · 3 comments ·
Maintainers usually reply within 9 days
-
Difficulty 3/5 1-2 days Newbie friendliness 63/100
Maintainers usually reply within 9 days
-
<stdfloat>May be free again @shreyas-s1403 claimed this 12 days ago, and no pull request is open. Open
Difficulty 4/5 3-5 days Newbie friendliness 45/100
fmtlib/fmt#4725 · 10 comments · 1 reaction ·
Maintainers usually reply within 9 days
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
fmtlib/fmt#4518 · 1 comment · 6 reactions ·
Maintainers usually reply within 9 days
-
failed to print error code `:s` fail on windows due to encoding errorMay be free again @shreyas-s1403 claimed this 12 days ago, and no pull request is open. Open
Difficulty 4/5 3-5 days Newbie friendliness 35/100
fmtlib/fmt#4436 · 11 comments ·
Maintainers usually reply within 9 days
Similar issues
-
bug libcudf
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 2 days
-
level/task module/cloud monitoring type/maintenance
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
LadybirdBrowser/ladybird#13809 ·
Maintainers usually reply within 1 day
-
bug module:nodes tests
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
rocketride-org/rocketride-server#3020 ·
Maintainers usually reply within 2 days
-
clang:frontend
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
llvm/llvm-project#238916 · 6 comments ·
Maintainers usually reply within 1 day