Decide what an event id in a public survey link is allowed to attach to

Open
#2,969 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Active
Tech stack
rails, ruby
Domain
backend, security

Research direction

Read PublicFormsController#set_event, EventSurveyCompletions#offered?, and app/views/events/_form_actions_menu.html.erb, along with issue #2768. First, get a product decision on whether links should be event-specific, restricted to delivered surveys, or allow the current behavior. Then implement the chosen rule and confirm the Forms menu and event attachment behavior match that decision.

Written by the indexing model from the issue text.

Description

blocked event mgmt forms stakeholder-question

Blocked on a product decision — what a shared survey link may claim. No code until that's settled, because the obvious tightening would remove a link staff can use today.

What's there now

#2768 lets a standalone survey be shared as /f/:slug?event=N, and PublicFormsController#set_event validates the id against EventSurveyCompletions.survey_allowed_for_event? before attaching it to the submission.

That check is per kind of event, not per event: EventSurveyCompletions#offered? returns true in its else branch, so the attendee survey (post_event_survey) is allowed for every event, and the scholarship survey for every paid one. The id is a bearer token in a public, account-free URL, so anyone who edits it can:

  • file a survey response against any event id they like, and
  • make a Surveys column appear on that event's registrants roster (#roles counts a role as answered once any submission carries the event).

It can't touch an existing registrant's completion state — #completions is keyed on the roster's own person ids — and app/views/events/_form_actions_menu.html.erb deliberately offers the attendee-survey link on every event, which is what makes the loose rule useful.

The decision

  • Is a shared survey link meant to be event-specific and unguessable (signed/obfuscated param), or is a plain event id acceptable because the blast radius is a spurious admin-side column?
  • Should attachment narrow to events whose callouts actually deliver that survey (delivered_roles)? That is the tight rule, and it would drop the attendee-survey link from the Forms menu on every event that has no feedback callout — a visible loss for staff.
  • Or leave the rule and handle noise after the fact (e.g. let an admin detach a submission from an event)?

Each answer implies different code; pick one and the change is small.

Dominant language
Ruby
Stars
15
Forks
28
Avg merge
14h 29m
Merged PRs (30d)
292

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rubyforgood/awbw

All issues in rubyforgood/awbw

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.