Decide what an event id in a public survey link is allowed to attach to

Aperta
#2,969 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
25/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
rails, ruby
Ambito
backend, security

Direzione di ricerca

Read PublicFormsController#set_event, EventSurveyCompletions#offered?, and app/views/events/_form_actions_menu.html.erb, along with issue #2768. First, get a product decision on whether links should be event-specific, restricted to delivered surveys, or allow the current behavior. Then implement the chosen rule and confirm the Forms menu and event attachment behavior match that decision.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

blocked event mgmt forms stakeholder-question

Blocked on a product decision — what a shared survey link may claim. No code until that's settled, because the obvious tightening would remove a link staff can use today.

What's there now

#2768 lets a standalone survey be shared as /f/:slug?event=N, and PublicFormsController#set_event validates the id against EventSurveyCompletions.survey_allowed_for_event? before attaching it to the submission.

That check is per kind of event, not per event: EventSurveyCompletions#offered? returns true in its else branch, so the attendee survey (post_event_survey) is allowed for every event, and the scholarship survey for every paid one. The id is a bearer token in a public, account-free URL, so anyone who edits it can:

  • file a survey response against any event id they like, and
  • make a Surveys column appear on that event's registrants roster (#roles counts a role as answered once any submission carries the event).

It can't touch an existing registrant's completion state — #completions is keyed on the roster's own person ids — and app/views/events/_form_actions_menu.html.erb deliberately offers the attendee-survey link on every event, which is what makes the loose rule useful.

The decision

  • Is a shared survey link meant to be event-specific and unguessable (signed/obfuscated param), or is a plain event id acceptable because the blast radius is a spurious admin-side column?
  • Should attachment narrow to events whose callouts actually deliver that survey (delivered_roles)? That is the tight rule, and it would drop the attendee-survey link from the Forms menu on every event that has no feedback callout — a visible loss for staff.
  • Or leave the rule and handle noise after the fact (e.g. let an admin detach a submission from an event)?

Each answer implies different code; pick one and the change is small.

Lingua principale
Ruby
Stelle
15
Fork
28
Merge medio
14h 29m
PR unite (30g)
292

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di rubyforgood/awbw

Tutte le issue di rubyforgood/awbw

Issue simili

Altre issue su Ruby

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.