Decide what an event id in a public survey link is allowed to attach to
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 25/100
Línea de trabajo
Read PublicFormsController#set_event, EventSurveyCompletions#offered?, and app/views/events/_form_actions_menu.html.erb, along with issue #2768. First, get a product decision on whether links should be event-specific, restricted to delivered surveys, or allow the current behavior. Then implement the chosen rule and confirm the Forms menu and event attachment behavior match that decision.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Blocked on a product decision — what a shared survey link may claim. No code until that's settled, because the obvious tightening would remove a link staff can use today.
What's there now
#2768 lets a standalone survey be shared as /f/:slug?event=N, and PublicFormsController#set_event validates the id against EventSurveyCompletions.survey_allowed_for_event? before attaching it to the submission.
That check is per kind of event, not per event: EventSurveyCompletions#offered? returns true in its else branch, so the attendee survey (post_event_survey) is allowed for every event, and the scholarship survey for every paid one. The id is a bearer token in a public, account-free URL, so anyone who edits it can:
- file a survey response against any event id they like, and
- make a Surveys column appear on that event's registrants roster (
#rolescounts a role as answered once any submission carries the event).
It can't touch an existing registrant's completion state — #completions is keyed on the roster's own person ids — and app/views/events/_form_actions_menu.html.erb deliberately offers the attendee-survey link on every event, which is what makes the loose rule useful.
The decision
- Is a shared survey link meant to be event-specific and unguessable (signed/obfuscated param), or is a plain event id acceptable because the blast radius is a spurious admin-side column?
- Should attachment narrow to events whose callouts actually deliver that survey (
delivered_roles)? That is the tight rule, and it would drop the attendee-survey link from the Forms menu on every event that has no feedback callout — a visible loss for staff. - Or leave the rule and handle noise after the fact (e.g. let an admin detach a submission from an event)?
Each answer implies different code; pick one and the change is small.
- Lenguaje dominante
- Ruby
- Estrellas
- 15
- Forks
- 28
- Merge medio
- 14 h 29 min
- PR fusionados (30 d)
- 292
Preparar el entorno
Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.
- Incluye un Dockerfile o un archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de rubyforgood/awbw
-
blocked
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
rubyforgood/awbw#2824 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
rubyforgood/awbw#2822 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
rubyforgood/awbw#2160 ·
Los mantenedores suelen responder en 1 día
-
Update callout faq defualt text when the new person subscription launchesPosiblemente ocupada @maebeale la tomó hace 98 días. Abiertoblocked
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
rubyforgood/awbw#2095 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
rubyforgood/awbw#2088 ·
Los mantenedores suelen responder en 1 día
Todos los issues de rubyforgood/awbw
Issues similares
-
Bug Ruby
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
getsentry/sentry-ruby#3211 · 1 comentario ·
Los mantenedores suelen responder en 2 días
-
enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 66/100
internetee/registry#2984 ·
Los mantenedores suelen responder en 6 días
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
ecosyste-ms/issues#862 ·
Los mantenedores suelen responder en 1 día
-
Redis Lua error `@user_script:52: ERR value is not an integer or out of range` when `window_size` is configuredPosiblemente ocupada @mimosa la tomó hoy. Abiertobug
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 67/100
riscv/riscv-unified-db#2829 ·
Los mantenedores suelen responder en 1 día