Decide what an event id in a public survey link is allowed to attach to

Abierto
#2,969 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
25/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
rails, ruby
Área
backend, security

Línea de trabajo

Read PublicFormsController#set_event, EventSurveyCompletions#offered?, and app/views/events/_form_actions_menu.html.erb, along with issue #2768. First, get a product decision on whether links should be event-specific, restricted to delivered surveys, or allow the current behavior. Then implement the chosen rule and confirm the Forms menu and event attachment behavior match that decision.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

blocked event mgmt forms stakeholder-question

Blocked on a product decision — what a shared survey link may claim. No code until that's settled, because the obvious tightening would remove a link staff can use today.

What's there now

#2768 lets a standalone survey be shared as /f/:slug?event=N, and PublicFormsController#set_event validates the id against EventSurveyCompletions.survey_allowed_for_event? before attaching it to the submission.

That check is per kind of event, not per event: EventSurveyCompletions#offered? returns true in its else branch, so the attendee survey (post_event_survey) is allowed for every event, and the scholarship survey for every paid one. The id is a bearer token in a public, account-free URL, so anyone who edits it can:

  • file a survey response against any event id they like, and
  • make a Surveys column appear on that event's registrants roster (#roles counts a role as answered once any submission carries the event).

It can't touch an existing registrant's completion state — #completions is keyed on the roster's own person ids — and app/views/events/_form_actions_menu.html.erb deliberately offers the attendee-survey link on every event, which is what makes the loose rule useful.

The decision

  • Is a shared survey link meant to be event-specific and unguessable (signed/obfuscated param), or is a plain event id acceptable because the blast radius is a spurious admin-side column?
  • Should attachment narrow to events whose callouts actually deliver that survey (delivered_roles)? That is the tight rule, and it would drop the attendee-survey link from the Forms menu on every event that has no feedback callout — a visible loss for staff.
  • Or leave the rule and handle noise after the fact (e.g. let an admin detach a submission from an event)?

Each answer implies different code; pick one and the change is small.

Lenguaje dominante
Ruby
Estrellas
15
Forks
28
Merge medio
14 h 29 min
PR fusionados (30 d)
292

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de rubyforgood/awbw

Todos los issues de rubyforgood/awbw

Issues similares

Más issues de Ruby

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.