Shorter rate limit in the same header replaces a longer one
Maintainers usually reply within 2 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 76/100
Research direction
Read lib/sentry/transport/http_transport.rb around parse_rate_limit_header (the linked lines 158–165) and check the rate-limiting spec cited in the issue. Reproduce the behavior with 3600:error:organization, 0:error:project; done means the longer limit is retained for the shared category and a regression test covers the case.
Written by the indexing model from the issue text.
Description
handle_rate_limited_response keeps the longer limit across responses. Within one X-Sentry-Rate-Limits header, parse_rate_limit_header keeps the last group for each category (http_transport.rb#L158-L165). With 3600:error:organization, 0:error:project, errors are not limited, and the SDK starts sending them before the longer quota expires.
- The spec says: "Always keep the maximum rate limit if multiple rate limits reference the same category."
@itsrayeedscodespace reported this bug in the Rust SDK in getsentry/sentry-rust#1409. A check of the other SDKs found the same behavior here.
via @szokeasaurusrex.
--
- Dominant language
- Ruby
- Stars
- 990
- Forks
- 552
- Avg merge
- 2d 16h
- Merged PRs (30d)
- 29
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from getsentry/sentry-ruby
-
Events dropped client-side for size are only logged at debug level and not recorded as lostPossibly taken @sentry-junior claimed this today. OpenBug Junior: repro Ruby
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
getsentry/sentry-ruby#3209 · 2 comments · 1 reaction ·
Maintainers usually reply within 2 days
-
with_child_span drops spans when blocks exit via break, return, or throwPossibly taken @itsrayeedscodespace claimed this 1 day ago. OpenBug Ruby Traces Waiting for: Product Owner
Difficulty 2/5 1-3 hours Newbie friendliness 38/100
getsentry/sentry-ruby#3206 · 1 comment ·
Maintainers usually reply within 2 days
-
Let apps choose how the client IP on events is determinedPossibly taken @sl0thentr0py claimed this 11 days ago. OpenImprovement Ruby
getsentry/sentry-ruby#3180 · 2 comments · 1 reaction · 1 assignee ·
Maintainers usually reply within 2 days
-
breaking change Next Major
Difficulty 2/5 1-3 hours Newbie friendliness 58/100
getsentry/sentry-ruby#3176 · 1 comment ·
Maintainers usually reply within 2 days
-
With `register_error_subscriber`, view errors are reported twice: the wrapper by the middleware, and its cause by the error subscriberPossibly taken @sl0thentr0py claimed this 13 days ago. OpenBug Ruby
Difficulty 4/5 1-2 days Newbie friendliness 57/100
getsentry/sentry-ruby#3166 · 1 comment · 1 assignee ·
Maintainers usually reply within 2 days
All issues in getsentry/sentry-ruby
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
internetee/registry#2984 ·
Maintainers usually reply within 6 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
ecosyste-ms/issues#862 ·
Maintainers usually reply within 1 day
-
Redis Lua error `@user_script:52: ERR value is not an integer or out of range` when `window_size` is configuredPossibly taken @mimosa claimed this today. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
riscv/riscv-unified-db#2829 ·
Maintainers usually reply within 1 day
-
⛓️ Security Difficulty: Easy Good First Issue Help Wanted ruby Type: Bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
rubyforgood/casa#7404 ·
Maintainers usually reply within 1 day