Delete unused args argument from main() in Python files
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 80/100
Research direction
The issue lists 30 Python files under rclpy/actions, rclpy/executors, rclpy/guard_conditions, rclpy/services, and rclpy/topics. In each file, locate the main() function definition and change its signature from def main(args=None): to def main():. Then find the call to rclpy.init(args=args) and change it to rclpy.init(). Run the examples to ensure they still start correctly.
Written by the indexing model from the issue text.
Description
These files define main(args=None) and pass args to rclpy.init(args=args). However, nothing ever calls main() with an args argument, so this parameter does nothing.
Modify the following files to delete the args argument from main() (so the signature is def main():) and call rclpy.init() without passing args:
rclpy/actions/minimal_action_client/examples_rclpy_minimal_action_client/client.pyrclpy/actions/minimal_action_client/examples_rclpy_minimal_action_client/client_asyncio.pyrclpy/actions/minimal_action_client/examples_rclpy_minimal_action_client/client_cancel.pyrclpy/actions/minimal_action_client/examples_rclpy_minimal_action_client/client_not_composable.pyrclpy/actions/minimal_action_server/examples_rclpy_minimal_action_server/server.pyrclpy/actions/minimal_action_server/examples_rclpy_minimal_action_server/server_defer.pyrclpy/actions/minimal_action_server/examples_rclpy_minimal_action_server/server_not_composable.pyrclpy/actions/minimal_action_server/examples_rclpy_minimal_action_server/server_queue_goals.pyrclpy/actions/minimal_action_server/examples_rclpy_minimal_action_server/server_single_goal.pyrclpy/executors/examples_rclpy_executors/callback_group.pyrclpy/executors/examples_rclpy_executors/composed.pyrclpy/executors/examples_rclpy_executors/custom_callback_group.pyrclpy/executors/examples_rclpy_executors/custom_executor.pyrclpy/executors/examples_rclpy_executors/listener.pyrclpy/executors/examples_rclpy_executors/talker.pyrclpy/guard_conditions/examples_rclpy_guard_conditions/trigger_guard_condition.pyrclpy/services/minimal_client/examples_rclpy_minimal_client/client.pyrclpy/services/minimal_client/examples_rclpy_minimal_client/client_async.pyrclpy/services/minimal_client/examples_rclpy_minimal_client/client_async_callback.pyrclpy/services/minimal_client/examples_rclpy_minimal_client/client_async_member_function.pyrclpy/services/minimal_service/examples_rclpy_minimal_service/service.pyrclpy/services/minimal_service/examples_rclpy_minimal_service/service_member_function.pyrclpy/topics/minimal_publisher/examples_rclpy_minimal_publisher/publisher_local_function.pyrclpy/topics/minimal_publisher/examples_rclpy_minimal_publisher/publisher_member_function.pyrclpy/topics/minimal_publisher/examples_rclpy_minimal_publisher/publisher_member_function_with_wait_for_all_acked.pyrclpy/topics/minimal_publisher/examples_rclpy_minimal_publisher/publisher_old_school.pyrclpy/topics/minimal_subscriber/examples_rclpy_minimal_subscriber/subscriber_lambda.pyrclpy/topics/minimal_subscriber/examples_rclpy_minimal_subscriber/subscriber_member_function.pyrclpy/topics/minimal_subscriber/examples_rclpy_minimal_subscriber/subscriber_old_school.pyrclpy/topics/pointcloud_publisher/examples_rclpy_pointcloud_publisher/pointcloud_publisher.py
- Dominant language
- C++
- Stars
- 970
- Forks
- 365
- Avg merge
- 12d 20h
- Merged PRs (30d)
- 1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ros2/examples
-
good first issue
Difficulty 1/5 Under an hour Newbie friendliness 85/100
-
good first issue
Difficulty 1/5 Under an hour Newbie friendliness 85/100
-
good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
good first issue
Difficulty 1/5 Under an hour Newbie friendliness 85/100
-
good first issue
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Similar issues
-
bug build
Difficulty 1/5 Under an hour Newbie friendliness 91/100
facebookincubator/velox#19194 ·
-
JIT-compiled number -> Decimal conversion silently overflows instead of raising DECIMAL_OVERFLOW Openfuzz
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
ClickHouse/ClickHouse#122114 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
module/agent platform/macos type/bug/regression
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
enhancement PyCDE
Difficulty 2/5 1-3 hours Newbie friendliness 78/100