Delete not_composable examples from examples_rclcpp_minimal_action_client
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 75/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- cpp
- Domain
- documentation
Research direction
Locate the three .cpp files in examples_rclcpp_minimal_action_client, remove them, then update CMakeLists.txt and README.md in the same directory. Verify the build still works after deletion by running the CMake configuration and checking that the executables are no longer listed.
Written by the indexing model from the issue text.
Description
The following examples in examples_rclcpp_minimal_action_client do not follow recommended composable node practices and should be deleted:
rclcpp/actions/minimal_action_client/not_composable.cpprclcpp/actions/minimal_action_client/not_composable_with_cancel.cpprclcpp/actions/minimal_action_client/not_composable_with_feedback.cpp
Please also remove the corresponding executables and references from rclcpp/actions/minimal_action_client/CMakeLists.txt and rclcpp/actions/minimal_action_client/README.md.
- Dominant language
- C++
- Stars
- 970
- Forks
- 365
- Avg merge
- 12d 20h
- Merged PRs (30d)
- 1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ros2/examples
-
good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
-
good first issue
Difficulty 1/5 Under an hour Newbie friendliness 85/100
-
good first issue
Difficulty 1/5 Under an hour Newbie friendliness 85/100
-
good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
good first issue
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Similar issues
-
bug build
Difficulty 1/5 Under an hour Newbie friendliness 91/100
facebookincubator/velox#19194 ·
-
JIT-compiled number -> Decimal conversion silently overflows instead of raising DECIMAL_OVERFLOW Openfuzz
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
ClickHouse/ClickHouse#122114 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
module/agent platform/macos type/bug/regression
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
enhancement PyCDE
Difficulty 2/5 1-3 hours Newbie friendliness 78/100