Releases with non-version tags are named d-<tag> instead of dev-<tag>
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
Research direction
Start in src/Repository/Release.php at simplifyReleaseName(), which cuts the last two characters of the first dash-separated part and so turns dev-nightly into d-nightly. Read GitHubRelease::getTagName() in src/Repository/GitHub/GitHubRelease.php for the dev- fallback that already works. Remove the #[Skip] on fromApiResponseNamesUnparsableReleaseAsDevBranch in tests/Unit/Repository/GitHub/GitHubReleaseTest.php, then run vendor/bin/testo --filter=fromApiResponseNamesUnparsableReleaseAsDevBranch; done when that test passes and numeric versions still lose only their trailing .0. Issue #49 may replace this lookup, so check it first.
Written by the indexing model from the issue text.
Description
Description
A GitHub release whose tag and name are not valid versions is named d-<tag> instead of dev-<tag>. For a release with tag_name: nightly and name: Nightly, getName() returns d-nightly. The versions command shows this name, and satisfies() checks constraints against it.
GitHubRelease::getTagName() correctly falls back to dev-nightly. Release::simplifyReleaseName() then normalizes the name, splits it on - and always cuts the last two characters of the first part. That step is meant to strip the .0 that VersionParser::normalize() appends to numeric versions (2024.1.0.0 becomes 2024.1.0), but for dev-nightly it turns dev into d.
Steps to reproduce
- Remove
#[Skip]fromGitHubReleaseTest::fromApiResponseNamesUnparsableReleaseAsDevBranch. - Run
vendor/bin/testo --filter=fromApiResponseNamesUnparsableReleaseAsDevBranch.
Additional context
The release lookup may be replaced by DLoad in #49, in which case this code goes away.
- Dominant language
- PHP
- Stars
- 30
- Forks
- 15
- Avg merge
- 45m
- Merged PRs (30d)
- 11
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from roadrunner-php/cli
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
roadrunner-php/cli#69 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
roadrunner-php/cli#68 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
roadrunner-php/cli#67 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
roadrunner-php/cli#62 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
roadrunner-php/cli#60 ·
Maintainers usually reply within 1 day
All issues in roadrunner-php/cli
Similar issues
-
Python 3.15 supportPossibly taken @amnesiaof claimed this today. OpenL: python L: python:uv
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
dependabot/dependabot-core#16524 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
crazy-goat/rabbit-stream#830 ·
Maintainers usually reply within 1 day
-
sync-en
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
sync-en
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 4 days
-
Перевод устарел
Difficulty 2/5 1-3 hours Newbie friendliness 70/100