Unknown --os or --arch still fetches the releases before failing
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 75/100
Research direction
Start with the rr get command and the existing --location validation, which already rejects bad input before any request; the unknown --os/--arch path currently only logs a warning and then fetches releases. Reproduce with rr get --os=plan9 and check that the release request happens before the failure. Done when an unknown OS or architecture fails before any GitHub API call, and FailureTest::rejectsUnknownPlatformWithoutRequests from #66 passes. Check whether #49 (DLoad) changes the release lookup first.
Written by the indexing model from the issue text.
Description
Description
An unknown --os or --arch value is only a warning (Possibly invalid operating system (--os=plan9) option). rr get then fetches the whole release list from the GitHub API and fails only afterwards with Could not find any available RoadRunner binary version which meets criterion. Each such call spends GitHub API requests (the anonymous limit is 60 per hour) on a request that can never succeed.
Expected: an unknown OS or architecture is rejected before any request, like an invalid --location already is.
Steps to reproduce
- Run
rr get --os=plan9(or--arch=sparc). - The releases are requested before the command fails.
Additional context
Found by the acceptance tests in #66 (FailureTest::rejectsUnknownPlatformWithoutRequests). The release lookup may be replaced by DLoad in #49.
- Dominant language
- PHP
- Stars
- 30
- Forks
- 15
- Avg merge
- 45m
- Merged PRs (30d)
- 11
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from roadrunner-php/cli
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
roadrunner-php/cli#69 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
roadrunner-php/cli#67 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
roadrunner-php/cli#62 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
roadrunner-php/cli#61 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
roadrunner-php/cli#60 ·
Maintainers usually reply within 1 day
All issues in roadrunner-php/cli
Similar issues
-
sync-en
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
sync-en
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 4 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
Refund Analytics Tool — “Check” Button Fails to Render in WooCommerce 11.2.1Possibly taken @MinhazI claimed this today. OpenBug Reports/Analytics type: community contribution
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
woocommerce/woocommerce#69689 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 60/100
Maintainers usually reply within 2 days