--stability=rc is treated as dev
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
Research direction
Start in src/Environment/Stability.php, where Stability::toInt() maps the value passed by --stability to a weight and returns 0 for unknown input. Make the lookup case-insensitive so rc and RC both resolve to the RC weight. Done when --stability=rc rejects 3.5.0-beta.1 and still accepts RC and stable releases. The acceptance test VersionSelectionTest::prefersReleaseCandidateOverOlderBeta is mentioned in #66, so check whether it exists in your branch before relying on it.
Written by the indexing model from the issue text.
Description
Description
--stability=rc (lower case, the spelling Composer and RoadRunner tags use) is not recognised: Stability only knows RC. The command prints Possibly invalid stability (--stability=rc) and then Stability::toInt() maps the unknown value to weight 0, so the minimum stability silently becomes dev and alpha/beta releases are accepted too.
Expected: rc and RC are the same stability, as in Composer; --stability=rc admits only RC and stable releases.
Steps to reproduce
- With releases
v3.5.0-rc.1,v3.5.0-beta.1andv3.4.0, runrr get --stability=rc --filter=3.5.0-beta.1. - The beta is installed instead of failing the stability check;
--stability=RCrejects it.
Additional context
Found by the acceptance tests in #66 (VersionSelectionTest::prefersReleaseCandidateOverOlderBeta, together with #58: lower-case -rc tags also sort below -beta ones). The release lookup may be replaced by DLoad in #49.
- Dominant language
- PHP
- Stars
- 30
- Forks
- 15
- Avg merge
- 9h 37m
- Merged PRs (30d)
- 16
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
fe: spell out "Auto increment" in the table editor, "AI" reads as artificial intelligence todayOpen
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
landsman/adminer-desktop#120 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
-
L: java:gradle L: java:maven L: ruby:bundler T: bug 🐞
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
dependabot/dependabot-core#16547 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
glpi-project/glpi#25922 ·
Maintainers usually reply within 1 day