[iOS][Fabric] Changing Dynamic Type while the app is running does not re-lay out text (root not dirtied on a layout-context-only change)
Maintainers usually reply within 2 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 45/100
Research direction
Start with RootShadowNode.cpp and inspect RootShadowNode::clone, then follow layoutContext into YogaLayoutableShadowNode::configureYogaTree. The issue identifies the three layout-context inputs that need to trigger layout dirtiness and explains why comparing the full context would be too broad. Reproduce the Dynamic Type change on iOS with the New Architecture, then verify existing layout tests cover the context changes and that text relays out after the change.
Written by the indexing model from the issue text.
Description
Description
On iOS with the New Architecture, changing the system text size (Dynamic Type) while the app is running has no visible effect on text already on screen. React Native receives the new fontSizeMultiplier, but no layout pass runs, so text keeps its launch-time size until the app is restarted. Text mounted after the change can pick up the new size, which produces mixed layouts.
Steps to reproduce
- Build a Release app with React Native 0.88.1 (New Architecture) and any
<Text>that hasallowFontScalingleft at its default. - Launch it on an iOS simulator or device.
- Without closing the app, change the text size (Settings › Display & Brightness › Text Size, or on a simulator
xcrun simctl ui <udid> content_size accessibility-extra-large). - Return to the app.
Expected: text re-lays out at the new size.
Actual: nothing changes, in either direction. Relaunching renders the new size correctly.
Root cause
-
RCTFabricSurfacehandlesUIContentSizeCategoryDidChangeNotificationby calling_updateLayoutContextwith the newfontSizeMultiplier, which reachesSurfaceHandler::constraintLayout. That commitsRootShadowNode::clone(propsParserContext, layoutConstraints, layoutContext). -
RootShadowNode::cloneonly callsdirtyLayout()when the layout constraints change:if (layoutConstraints != getConcreteProps().layoutConstraints) { newRootShadowNode->dirtyLayout(); } -
For a layout-context-only change, the root stays clean.
RootShadowNode::layoutIfNeededthen returns early (getIsLayoutClean()), solayoutTree→configureYogaTreenever runs. -
That means the existing font-scale handling in
YogaLayoutableShadowNode::configureYogaTreenever gets a chance to run, even thoughenableFontScaleChangesUpdatingLayoutdefaults totrue. That code marks measurable nodes dirty when theirfontSizeMultiplierdiffers from the new one. -
pointScaleFactorandswapLeftAndRightInRTLare consumed byconfigureYogaTreein the same way, so a change to either alone has the same problem.
The same code is on main as of 2026-11-10 (RootShadowNode.cpp last changed in 178c30d7ac). #59285 makes ParagraphShadowNode drop content built for another fontSizeMultiplier, but that only helps once a layout pass actually runs.
Proposed fix
Dirty the root when any layout-context input that configureYogaTree consumes changes:
- if (layoutConstraints != getConcreteProps().layoutConstraints) {
+ const auto& previousContext = getConcreteProps().layoutContext;
+ if (layoutConstraints != getConcreteProps().layoutConstraints ||
+ layoutContext.fontSizeMultiplier != previousContext.fontSizeMultiplier ||
+ layoutContext.pointScaleFactor != previousContext.pointScaleFactor ||
+ layoutContext.swapLeftAndRightInRTL !=
+ previousContext.swapLeftAndRightInRTL) {
newRootShadowNode->dirtyLayout();
}
The full LayoutContext == is deliberately not used: it also compares affectedNodes (a per-pass pointer) and the viewport fields, which would dirty the root on unrelated commits.
I traced this in source and reproduced the symptom in a Release build. I have not run the patched build myself, because our app uses the prebuilt React Native core.
Versions
React Native 0.88.1 (also present on 0.88-stable and main), Expo SDK 58, iOS 26.5 simulator, New Architecture, Hermes.
- Dominant language
- C++
- Stars
- 127k
- Forks
- 25.5k
- Avg merge
- 3d 22h
- Merged PRs (30d)
- 235
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from react/react-native
-
Needs: Author Feedback Needs: Repro
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
react/react-native#60059 · 1 comment ·
Maintainers usually reply within 2 days
-
Needs: Triage :mag:
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
react/react-native#60000 ·
Maintainers usually reply within 2 days
-
`yarn test-ios` exits before building RNTester: `objc-test.sh` launches the WebSocket server script #59433 deletedPossibly taken @lazerg claimed this 4 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
react/react-native#59939 ·
Maintainers usually reply within 2 days
-
iOS Fabric pointer-handler reset leaves the next lone touch non-primaryPossibly taken @alleneubank claimed this 6 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
react/react-native#59919 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
react/react-native#59722 ·
Maintainers usually reply within 2 days
All issues in react/react-native
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
petercorke/robotics-toolbox-python#943 · 1 comment ·
Maintainers usually reply within 1 day
-
area:build bug
Difficulty 1/5 Under an hour Newbie friendliness 90/100
NatronGitHub/openfx-arena#71 ·
Maintainers usually reply within 1 day
-
upstream-blocked
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ROCm/FastFlowLM#1057 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
NatronGitHub/openfx-gmic#45 ·
Maintainers usually reply within 1 day