ReactNative-application.cmake links autolinked libraries to common_flags with the plain target_link_libraries signature, so a library that uses PRIVATE fails the app's CMake configure
Maintainers usually reply within 2 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 70/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- cmake, react-native
- Domain
- build-system
Research direction
Open ReactAndroid/cmake-utils/ReactNative-application.cmake and find the foreach(autolinked_library ...) block around line 97 (0.88.1) / 108 (nightly) plus the ${APP_CODEGEN_TARGET} link just below it; both use the plain target_link_libraries form that conflicts with libraries linking themselves via PRIVATE/PUBLIC. Read the reproducer repo's modules/keyword-linking/android/CMakeLists.txt to see the failing combination, then run ./reproduce.sh in the reproducer to confirm the configure error before editing. Done means the loop uses a keyword signature consistently and ./gradlew :app:configureCMakeDebug[arm64-v8a] exits 0 while a library that links nothing or links plainly still configures.
Written by the indexing model from the issue text.
Description
Description
ReactNative-application.cmake links every autolinked library to common_flags with the plain signature:
foreach(autolinked_library ${AUTOLINKED_LIBRARIES})
target_link_libraries(${autolinked_library} common_flags)
endforeach()
CMake refuses to mix the plain and the keyword signatures on one target, so an autolinked library whose own CMakeLists.txt links its target with PRIVATE, PUBLIC or INTERFACE fails the configure of every app that installs it. The app-level codegen target is linked the same way (target_link_libraries(${APP_CODEGEN_TARGET} common_flags)).
Steps to reproduce
-
Clone the reproducer and run
./reproduce.sh(react-native 0.88.1) or./reproduce.sh nightly.ReproducerAppdepends on a local library,modules/keyword-linking, whosereact-native.config.jsgives AndroidlibraryName: 'keywordlinking'andcmakeListsPath: 'CMakeLists.txt', and whoseandroid/CMakeLists.txtis:add_library(react_codegen_keywordlinking SHARED keyword-linking.cpp) target_link_libraries(react_codegen_keywordlinking PRIVATE fbjni jsi reactnative) -
The script runs
npm install, then./gradlew :app:configureCMakeDebug[arm64-v8a] -PreactNativeArchitectures=arm64-v8ainReproducerApp/android.
Expected: the app's CMake build configures, as it does when the library drops PRIVATE.
Seen: the configure fails at ReactNative-application.cmake:97 on 0.88.1 and at :108 on 0.90.0-nightly-20261113-6d587e873. The script exits 1 while this shows and 0 once the configure passes.
React Native Version
0.88.1
Affected Platforms
Runtime - Android, Build - Windows
Output of npx @react-native-community/cli info
System:
OS: Windows 11 10.0.26300
CPU: "(32) x64 AMD Ryzen 9 9950X3D 16-Core Processor "
Binaries:
Node:
version: 26.12.1
npm:
version: 12.2.1
Languages:
Java:
version: 17.0.20.1
npmPackages:
"@react-native-community/cli":
installed: 20.2.0
wanted: 20.2.0
react:
installed: 19.3.0
wanted: 19.3.0
react-native:
installed: 0.88.1
wanted: 0.88.1
Android:
hermesEnabled: true
newArchEnabled: true
Stacktrace or Logs
react-native 0.90.0-nightly-20261113-6d587e873
$ ./gradlew :app:configureCMakeDebug[arm64-v8a] -PreactNativeArchitectures=arm64-v8a
gradle exit 1
C/C++: CMake Error at ReproducerApp/node_modules/react-native/ReactAndroid/cmake-utils/ReactNative-application.cmake:108 (target_link_libraries):
C/C++: The keyword signature for target_link_libraries has already been used with
C/C++: the target "react_codegen_keywordlinking". All uses of
C/C++: target_link_libraries with a target must be either all-keyword or
C/C++: all-plain.
C/C++: The uses of the keyword signature are here:
C/C++: * ReproducerApp/node_modules/keyword-linking/android/CMakeLists.txt:7 (target_link_libraries)
C/C++: Call Stack (most recent call first):
C/C++: CMakeLists.txt:31 (include)
SUMMARY: defect: the app's CMake configure fails, as ReactNative-application.cmake links react_codegen_keywordlinking with the plain signature and its own CMakeLists uses PRIVATE (react-native 0.90.0-nightly-20261113-6d587e873)
MANDATORY Reproducer
https://github.com/YevheniiKotyrlo/react-native-autolinked-keyword-link-signature
Screenshots and Videos
No response
- Dominant language
- C++
- Stars
- 127k
- Forks
- 25.5k
- Avg merge
- 3d 22h
- Merged PRs (30d)
- 235
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from react/react-native
-
Needs: Author Feedback Needs: Repro
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
react/react-native#60059 · 1 comment ·
Maintainers usually reply within 2 days
-
`yarn test-ios` exits before building RNTester: `objc-test.sh` launches the WebSocket server script #59433 deletedPossibly taken @lazerg claimed this 4 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
react/react-native#59939 ·
Maintainers usually reply within 2 days
-
iOS Fabric pointer-handler reset leaves the next lone touch non-primaryPossibly taken @alleneubank claimed this 6 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
react/react-native#59919 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
react/react-native#59722 ·
Maintainers usually reply within 2 days
-
Android: new WebSocket() crashes the app for a URL that OkHttp or java.net.URI rejectsPossibly taken @sorinc03 claimed this 14 days ago. Open🌐Networking Needs: Author Feedback Needs: Repro Platform: Android
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
react/react-native#59704 · 1 comment ·
Maintainers usually reply within 2 days
All issues in react/react-native
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
petercorke/robotics-toolbox-python#943 · 1 comment ·
Maintainers usually reply within 1 day
-
area:build bug
Difficulty 1/5 Under an hour Newbie friendliness 90/100
NatronGitHub/openfx-arena#71 ·
Maintainers usually reply within 1 day
-
upstream-blocked
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ROCm/FastFlowLM#1057 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
NatronGitHub/openfx-gmic#45 ·
Maintainers usually reply within 1 day