@react-native/[email protected] assigns module.exports inside an ES module, so non-Metro web bundles crash

Aberta Para iniciantes
#60,091 1 comentário 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 2 dias

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
2/5
Tempo estimado
1-3 horas
Facilidade para iniciantes
74/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
javascript, react-native, webpack
Domínio
frontend, web-dev

Direção de pesquisa

A issue identifica @react-native/assets-registry/registry.js como o arquivo com falha e informa os exports nomeados que o substituirão. Leia esse arquivo e confira as declarações do pacote; em seguida, execute um bundle web com webpack 5 ou Rspack que importe react-native-svg e use react-native-web como alias de react-native. A tarefa estará concluída quando o bundle carregar sem o erro de módulo ES e as importações nomeadas forem resolvidas.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Needs: Author Feedback Needs: Repro
Description

@react-native/[email protected] registry.js contains an import and then assigns module.exports. Rspack and webpack 5 treat a file with import as an ES module and throw when it assigns module.exports. The web bundle never evaluates past that file.

react-native-svg imports the named export, so any web bundle that includes it hits this on startup:

import { getAssetByID } from "@react-native/assets-registry/registry";

Metro accepts the mix, so native builds and Metro web builds do not throw.

This is not #48349. That issue was Flow syntax (export type) in the 0.76 file, fixed by #48458, which moved the types into comments and kept module.exports. The 0.88 file is a later rewrite: it imports AssetRegistry from react-native and still assigns module.exports. The published registry.d.ts already declares registerAsset and getAssetByID as named exports.

Published registry.js:

"use strict";

import { AssetRegistry } from "react-native";

/*::
export type {AssetDestPathResolver, PackagerAsset} from 'react-native';
*/

// eslint-disable-next-line @react-native/monorepo/no-commonjs-exports
module.exports = {
  registerAsset: AssetRegistry.registerAsset,
  getAssetByID: AssetRegistry.getAssetByID,
};

Replacing the assignment with named exports matches the .d.ts and lets the bundle load:

export const registerAsset = AssetRegistry.registerAsset;
export const getAssetByID = AssetRegistry.getAssetByID;
Steps to reproduce
  1. Install [email protected], react-native-web, and [email protected].
  2. Bundle a web entry that imports react-native-svg with Rspack or webpack 5, aliasing react-native to react-native-web.
  3. Load the bundle in a browser.
React Native Version

0.88.1

Affected Platforms

Runtime - Web

Output of npx @react-native-community/cli info

Not a stock React Native app. The failure is in the published @react-native/[email protected] package, loaded through [email protected] by an Rspack web build. react-native is 0.88.1 and react-native-web is 0.21.4.

Stacktrace or Logs
Uncaught (in promise) Error: ES Modules may not assign module.exports or exports.*, Use ESM export syntax, instead: .../node_modules/@react-native/assets-registry/registry.js

Rspack also reports, before the throw:

ESModulesLinkingWarning: export 'getAssetByID' (imported as 'getAssetByID') was not found in '@react-native/assets-registry/registry' (module has no exports)

from react-native-svg/lib/module/lib/resolveAssetUri.js.

Reproducer

The three accepted reproducer forms all bundle with Metro, and Metro does not throw on this file:

  • A pull request that edits RNTesterPlayground.js runs inside RNTester, which uses Metro.
  • An Expo Snack uses Metro.
  • The reproducer template is a Community CLI app, which also uses Metro.

The crash happens only when Rspack or webpack 5 bundles @react-native/assets-registry/registry.js. A project that reproduces it is a small web build that installs [email protected], react-native-web, and [email protected], aliases react-native to react-native-web, and bundles an entry that imports react-native-svg. Loading that bundle throws ES Modules may not assign module.exports from registry.js.

There is no public repository for that build yet.

Linguagem predominante
C++
Estrelas
127k
Forks
25.5k
Merge médio
3d 22h
PRs com merge (30d)
258

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de react/react-native

Todas as issues de react/react-native

Issues semelhantes

Mais issues de C++

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.