@react-native/[email protected] assigns module.exports inside an ES module, so non-Metro web bundles crash

未關閉 適合新手
#60,091 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 2 天內回覆

還沒有人認領這個 Issue。

評估

難度
2/5
預估耗時
1-3 小時
新手友好度
74/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
javascript, react-native, webpack
領域
frontend, web-dev

研究方向

issue 指出 @react-native/assets-registry/registry.js 是發生錯誤的檔案,並提供了要替換的具名匯出。閱讀該檔案並檢查其 package 宣告;接著執行 webpack 5 或 Rspack 的 Web bundle,匯入 react-native-svg,並將 react-native 別名為 react-native-web。當 bundle 載入時沒有 ES 模組錯誤,且具名匯入都能解析,就算完成。

由索引模型根據 Issue 內容生成。

描述

Needs: Author Feedback Needs: Repro
Description

@react-native/[email protected] registry.js contains an import and then assigns module.exports. Rspack and webpack 5 treat a file with import as an ES module and throw when it assigns module.exports. The web bundle never evaluates past that file.

react-native-svg imports the named export, so any web bundle that includes it hits this on startup:

import { getAssetByID } from "@react-native/assets-registry/registry";

Metro accepts the mix, so native builds and Metro web builds do not throw.

This is not #48349. That issue was Flow syntax (export type) in the 0.76 file, fixed by #48458, which moved the types into comments and kept module.exports. The 0.88 file is a later rewrite: it imports AssetRegistry from react-native and still assigns module.exports. The published registry.d.ts already declares registerAsset and getAssetByID as named exports.

Published registry.js:

"use strict";

import { AssetRegistry } from "react-native";

/*::
export type {AssetDestPathResolver, PackagerAsset} from 'react-native';
*/

// eslint-disable-next-line @react-native/monorepo/no-commonjs-exports
module.exports = {
  registerAsset: AssetRegistry.registerAsset,
  getAssetByID: AssetRegistry.getAssetByID,
};

Replacing the assignment with named exports matches the .d.ts and lets the bundle load:

export const registerAsset = AssetRegistry.registerAsset;
export const getAssetByID = AssetRegistry.getAssetByID;
Steps to reproduce
  1. Install [email protected], react-native-web, and [email protected].
  2. Bundle a web entry that imports react-native-svg with Rspack or webpack 5, aliasing react-native to react-native-web.
  3. Load the bundle in a browser.
React Native Version

0.88.1

Affected Platforms

Runtime - Web

Output of npx @react-native-community/cli info

Not a stock React Native app. The failure is in the published @react-native/[email protected] package, loaded through [email protected] by an Rspack web build. react-native is 0.88.1 and react-native-web is 0.21.4.

Stacktrace or Logs
Uncaught (in promise) Error: ES Modules may not assign module.exports or exports.*, Use ESM export syntax, instead: .../node_modules/@react-native/assets-registry/registry.js

Rspack also reports, before the throw:

ESModulesLinkingWarning: export 'getAssetByID' (imported as 'getAssetByID') was not found in '@react-native/assets-registry/registry' (module has no exports)

from react-native-svg/lib/module/lib/resolveAssetUri.js.

Reproducer

The three accepted reproducer forms all bundle with Metro, and Metro does not throw on this file:

  • A pull request that edits RNTesterPlayground.js runs inside RNTester, which uses Metro.
  • An Expo Snack uses Metro.
  • The reproducer template is a Community CLI app, which also uses Metro.

The crash happens only when Rspack or webpack 5 bundles @react-native/assets-registry/registry.js. A project that reproduces it is a small web build that installs [email protected], react-native-web, and [email protected], aliases react-native to react-native-web, and bundles an entry that imports react-native-svg. Loading that bundle throws ES Modules may not assign module.exports from registry.js.

There is no public repository for that build yet.

主要語言
C++
星號
127k
分支
25.5k
平均合併
3 天 22 小時
30 天內合併 PR
258

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

react/react-native 的其他 Issue

查看 react/react-native 的全部 Issue

相似的 Issue

更多 C++ Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。