@react-native/[email protected] assigns module.exports inside an ES module, so non-Metro web bundles crash

Ouverte Adaptée aux débutants
#60,091 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 2 jours

Personne n'a encore pris cette issue.

Évaluation

Difficulté
2/5
Temps estimé
1-3 heures
Accessibilité débutants
74/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
javascript, react-native, webpack
Domaine
frontend, web-dev

Piste de recherche

L’issue identifie @react-native/assets-registry/registry.js comme le fichier en échec et indique les exports nommés de remplacement. Lis ce fichier et vérifie les déclarations de son package ; exécute ensuite un bundle web avec webpack 5 ou Rspack qui importe react-native-svg et utilise react-native-web comme alias de react-native. Le travail est terminé lorsque le bundle se charge sans l’erreur de module ES et que les imports nommés sont résolus.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Needs: Author Feedback Needs: Repro
Description

@react-native/[email protected] registry.js contains an import and then assigns module.exports. Rspack and webpack 5 treat a file with import as an ES module and throw when it assigns module.exports. The web bundle never evaluates past that file.

react-native-svg imports the named export, so any web bundle that includes it hits this on startup:

import { getAssetByID } from "@react-native/assets-registry/registry";

Metro accepts the mix, so native builds and Metro web builds do not throw.

This is not #48349. That issue was Flow syntax (export type) in the 0.76 file, fixed by #48458, which moved the types into comments and kept module.exports. The 0.88 file is a later rewrite: it imports AssetRegistry from react-native and still assigns module.exports. The published registry.d.ts already declares registerAsset and getAssetByID as named exports.

Published registry.js:

"use strict";

import { AssetRegistry } from "react-native";

/*::
export type {AssetDestPathResolver, PackagerAsset} from 'react-native';
*/

// eslint-disable-next-line @react-native/monorepo/no-commonjs-exports
module.exports = {
  registerAsset: AssetRegistry.registerAsset,
  getAssetByID: AssetRegistry.getAssetByID,
};

Replacing the assignment with named exports matches the .d.ts and lets the bundle load:

export const registerAsset = AssetRegistry.registerAsset;
export const getAssetByID = AssetRegistry.getAssetByID;
Steps to reproduce
  1. Install [email protected], react-native-web, and [email protected].
  2. Bundle a web entry that imports react-native-svg with Rspack or webpack 5, aliasing react-native to react-native-web.
  3. Load the bundle in a browser.
React Native Version

0.88.1

Affected Platforms

Runtime - Web

Output of npx @react-native-community/cli info

Not a stock React Native app. The failure is in the published @react-native/[email protected] package, loaded through [email protected] by an Rspack web build. react-native is 0.88.1 and react-native-web is 0.21.4.

Stacktrace or Logs
Uncaught (in promise) Error: ES Modules may not assign module.exports or exports.*, Use ESM export syntax, instead: .../node_modules/@react-native/assets-registry/registry.js

Rspack also reports, before the throw:

ESModulesLinkingWarning: export 'getAssetByID' (imported as 'getAssetByID') was not found in '@react-native/assets-registry/registry' (module has no exports)

from react-native-svg/lib/module/lib/resolveAssetUri.js.

Reproducer

The three accepted reproducer forms all bundle with Metro, and Metro does not throw on this file:

  • A pull request that edits RNTesterPlayground.js runs inside RNTester, which uses Metro.
  • An Expo Snack uses Metro.
  • The reproducer template is a Community CLI app, which also uses Metro.

The crash happens only when Rspack or webpack 5 bundles @react-native/assets-registry/registry.js. A project that reproduces it is a small web build that installs [email protected], react-native-web, and [email protected], aliases react-native to react-native-web, and bundles an entry that imports react-native-svg. Loading that bundle throws ES Modules may not assign module.exports from registry.js.

There is no public repository for that build yet.

Langage dominant
C++
Étoiles
127k
Forks
25.5k
Merge moyen
3 j 22 h
PR mergées (30 j)
258

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de react/react-native

Toutes les issues de react/react-native

Issues similaires

Plus d'issues C++

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.