`Appearance.setColorScheme` notifies no `change` listener, so `useColorScheme()` readers show the old scheme until the platform reports it
Mantenedores costumam responder em até 2 dias
Avaliação
- Dificuldade
- 3/5
- Tempo estimado
- 1-2 dias
- Facilidade para iniciantes
- 66/100
- Tipo de issue
- Bug
- Clareza
- Claramente especificada
- Status de atividade
- Ativa
- Stack de tecnologia
- android, javascript, react-native
Direção de pesquisa
Read Appearance.js and useColorScheme.js, especially the setColorScheme and addChangeListener behavior described in the issue. Use the linked reproducer to observe whether calling Appearance.setColorScheme updates hook subscribers in the same commit. Done when both readers show the new scheme together and the listener behavior matches its documented contract.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
Description
Appearance.setColorScheme(scheme) sets the value Appearance.getColorScheme() returns at once and emits no change. useColorScheme() subscribes through addChangeListener, so a component that reads it keeps the old scheme until the native module reports appearanceChanged, while a component that re-renders for another reason in the same press already reads the new one, and one commit shows both schemes. addChangeListener's doc says its listener hears "a call to setColorScheme()" (Appearance.js).
Steps to reproduce
- Clone https://github.com/YevheniiKotyrlo/rn-set-color-scheme-no-change and connect an Android device.
- Run
bash repro.sh, which buildsReproducerApp's release APK, installs and opens it, and taps the grey area once. By hand:yarn installandyarn androidinReproducerApp, then press the grey area once. - The press calls
Appearance.setColorScheme(next)and bumps a counter in the component that rendersAppearance.getColorScheme(); its sibling rendersuseColorScheme(). After each of its commits, each component logs what the screen shows, and achangelistener logs when it runs.
Expected: the commit the press makes shows the new scheme in both components.
Actual: that commit shows useColorScheme() dark beside Appearance.getColorScheme() light, and the useColorScheme() reader catches up only after the change listener runs.
React Native Version
0.88.1
Appearance.js and useColorScheme.js on main at b9a83f3a are the same files as in 0.88.1.
Affected Platforms
Runtime - Android
Output of npx @react-native-community/cli info
System:
OS: Windows 11 10.0.26300
CPU: "(32) x64 AMD Ryzen 9 9950X3D 16-Core Processor "
Memory: 128.21 GB / 255.67 GB
Binaries:
Node:
version: 26.12.1
path: C:\Program Files\nodejs\node.EXE
Yarn:
version: 1.22.22
path: C:\Users\…\AppData\Roaming\npm\yarn.CMD
npm:
version: 12.2.1
path: C:\Program Files\nodejs\npm.CMD
Watchman: Not Found
SDKs:
Android SDK: Not Found
Windows SDK:
AllowDevelopmentWithoutDevLicense: Enabled
Versions:
- 10.0.19041.0
- 10.0.26100.0
IDEs:
Android Studio: AI-262.9437.185.2621.16467767
Visual Studio: Not Found
Languages:
Java:
version: 17.0.20.1
path: C:\Program Files\Microsoft\jdk-17.0.20.101-hotspot\bin\javac.EXE
Ruby: Not Found
npmPackages:
"@react-native-community/cli":
installed: 20.2.0
wanted: 20.2.0
react:
installed: 19.3.0
wanted: 19.3.0
react-native:
installed: 0.88.1
wanted: 0.88.1
react-native-windows: Not Found
npmGlobalPackages:
"*react-native*": Not Found
Android:
hermesEnabled: true
newArchEnabled: true
iOS:
hermesEnabled: Not found
newArchEnabled: Not found
Stacktrace or Logs
react-native 0.88.1, release build, SM-S911B, Android 14
the Appearance.getColorScheme() reader committed: the screen shows useColorScheme() dark and Appearance.getColorScheme() dark (agree)
ready
press 1: Appearance.setColorScheme('light') and a state update
the Appearance.getColorScheme() reader committed: the screen shows useColorScheme() dark and Appearance.getColorScheme() light (DISAGREE)
change listener: light, 2 ms after the press
the useColorScheme() reader committed: the screen shows useColorScheme() light and Appearance.getColorScheme() light (agree)
RESULT: defect shows: after Appearance.setColorScheme a commit shows useColorScheme() and Appearance.getColorScheme() disagreeing, until the change listener runs
MANDATORY Reproducer
https://github.com/YevheniiKotyrlo/rn-set-color-scheme-no-change
- Linguagem predominante
- C++
- Estrelas
- 127k
- Forks
- 25.5k
- Merge médio
- 3d 22h
- PRs com merge (30d)
- 235
Preparar o ambiente
- Sem Dockerfile nem arquivo Docker Compose
- Tem um modelo de pull request
- Ler o guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de react/react-native
-
Needs: Author Feedback Needs: Repro
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 82/100
react/react-native#60059 · 1 comentário ·
Mantenedores costumam responder em até 2 dias
-
Needs: Triage :mag:
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 70/100
react/react-native#60000 ·
Mantenedores costumam responder em até 2 dias
-
`yarn test-ios` exits before building RNTester: `objc-test.sh` launches the WebSocket server script #59433 deletedTalvez já em andamento @lazerg assumiu há 4 dias. Aberta
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 76/100
react/react-native#59939 ·
Mantenedores costumam responder em até 2 dias
-
iOS Fabric pointer-handler reset leaves the next lone touch non-primaryTalvez já em andamento @alleneubank assumiu há 6 dias. Aberta
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 68/100
react/react-native#59919 ·
Mantenedores costumam responder em até 2 dias
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 70/100
react/react-native#59722 ·
Mantenedores costumam responder em até 2 dias
Todas as issues de react/react-native
Issues semelhantes
-
bug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 76/100
petercorke/robotics-toolbox-python#943 · 1 comentário ·
Mantenedores costumam responder em até 1 dia
-
area:build bug
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 90/100
NatronGitHub/openfx-arena#71 ·
Mantenedores costumam responder em até 1 dia
-
upstream-watcher: Netflix/vmaf cf677baaa039 is not portedTalvez já em andamento Um pull request vinculado a esta issue está aberto ou já foi mesclado. Abertaupstream-blocked
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 65/100
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
ROCm/FastFlowLM#1057 ·
Mantenedores costumam responder em até 1 dia
-
bug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 76/100
NatronGitHub/openfx-gmic#45 ·
Mantenedores costumam responder em até 1 dia