`Appearance.setColorScheme` notifies no `change` listener, so `useColorScheme()` readers show the old scheme until the platform reports it
Los mantenedores suelen responder en 2 días
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 66/100
- Tipo de issue
- Error
- Claridad
- Bien especificado
- Estado de actividad
- Activo
- Stack tecnológico
- android, javascript, react-native
Línea de trabajo
Read Appearance.js and useColorScheme.js, especially the setColorScheme and addChangeListener behavior described in the issue. Use the linked reproducer to observe whether calling Appearance.setColorScheme updates hook subscribers in the same commit. Done when both readers show the new scheme together and the listener behavior matches its documented contract.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Description
Appearance.setColorScheme(scheme) sets the value Appearance.getColorScheme() returns at once and emits no change. useColorScheme() subscribes through addChangeListener, so a component that reads it keeps the old scheme until the native module reports appearanceChanged, while a component that re-renders for another reason in the same press already reads the new one, and one commit shows both schemes. addChangeListener's doc says its listener hears "a call to setColorScheme()" (Appearance.js).
Steps to reproduce
- Clone https://github.com/YevheniiKotyrlo/rn-set-color-scheme-no-change and connect an Android device.
- Run
bash repro.sh, which buildsReproducerApp's release APK, installs and opens it, and taps the grey area once. By hand:yarn installandyarn androidinReproducerApp, then press the grey area once. - The press calls
Appearance.setColorScheme(next)and bumps a counter in the component that rendersAppearance.getColorScheme(); its sibling rendersuseColorScheme(). After each of its commits, each component logs what the screen shows, and achangelistener logs when it runs.
Expected: the commit the press makes shows the new scheme in both components.
Actual: that commit shows useColorScheme() dark beside Appearance.getColorScheme() light, and the useColorScheme() reader catches up only after the change listener runs.
React Native Version
0.88.1
Appearance.js and useColorScheme.js on main at b9a83f3a are the same files as in 0.88.1.
Affected Platforms
Runtime - Android
Output of npx @react-native-community/cli info
System:
OS: Windows 11 10.0.26300
CPU: "(32) x64 AMD Ryzen 9 9950X3D 16-Core Processor "
Memory: 128.21 GB / 255.67 GB
Binaries:
Node:
version: 26.12.1
path: C:\Program Files\nodejs\node.EXE
Yarn:
version: 1.22.22
path: C:\Users\…\AppData\Roaming\npm\yarn.CMD
npm:
version: 12.2.1
path: C:\Program Files\nodejs\npm.CMD
Watchman: Not Found
SDKs:
Android SDK: Not Found
Windows SDK:
AllowDevelopmentWithoutDevLicense: Enabled
Versions:
- 10.0.19041.0
- 10.0.26100.0
IDEs:
Android Studio: AI-262.9437.185.2621.16467767
Visual Studio: Not Found
Languages:
Java:
version: 17.0.20.1
path: C:\Program Files\Microsoft\jdk-17.0.20.101-hotspot\bin\javac.EXE
Ruby: Not Found
npmPackages:
"@react-native-community/cli":
installed: 20.2.0
wanted: 20.2.0
react:
installed: 19.3.0
wanted: 19.3.0
react-native:
installed: 0.88.1
wanted: 0.88.1
react-native-windows: Not Found
npmGlobalPackages:
"*react-native*": Not Found
Android:
hermesEnabled: true
newArchEnabled: true
iOS:
hermesEnabled: Not found
newArchEnabled: Not found
Stacktrace or Logs
react-native 0.88.1, release build, SM-S911B, Android 14
the Appearance.getColorScheme() reader committed: the screen shows useColorScheme() dark and Appearance.getColorScheme() dark (agree)
ready
press 1: Appearance.setColorScheme('light') and a state update
the Appearance.getColorScheme() reader committed: the screen shows useColorScheme() dark and Appearance.getColorScheme() light (DISAGREE)
change listener: light, 2 ms after the press
the useColorScheme() reader committed: the screen shows useColorScheme() light and Appearance.getColorScheme() light (agree)
RESULT: defect shows: after Appearance.setColorScheme a commit shows useColorScheme() and Appearance.getColorScheme() disagreeing, until the change listener runs
MANDATORY Reproducer
https://github.com/YevheniiKotyrlo/rn-set-color-scheme-no-change
- Lenguaje dominante
- C++
- Estrellas
- 127k
- Forks
- 25.5k
- Merge medio
- 3 d 22 h
- PR fusionados (30 d)
- 235
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de react/react-native
-
Needs: Author Feedback Needs: Repro
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
react/react-native#60059 · 1 comentario ·
Los mantenedores suelen responder en 2 días
-
Needs: Triage :mag:
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
react/react-native#60000 ·
Los mantenedores suelen responder en 2 días
-
`yarn test-ios` exits before building RNTester: `objc-test.sh` launches the WebSocket server script #59433 deletedPosiblemente ocupada @lazerg la tomó hace 4 días. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
react/react-native#59939 ·
Los mantenedores suelen responder en 2 días
-
iOS Fabric pointer-handler reset leaves the next lone touch non-primaryPosiblemente ocupada @alleneubank la tomó hace 6 días. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
react/react-native#59919 ·
Los mantenedores suelen responder en 2 días
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
react/react-native#59722 ·
Los mantenedores suelen responder en 2 días
Todos los issues de react/react-native
Issues similares
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
petercorke/robotics-toolbox-python#943 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
area:build bug
Dificultad 1/5 Menos de una hora Aptitud para principiantes 90/100
NatronGitHub/openfx-arena#71 ·
Los mantenedores suelen responder en 1 día
-
upstream-watcher: Netflix/vmaf cf677baaa039 is not portedPosiblemente ocupada Un pull request vinculado a esta issue está abierto o ya se fusionó. Abiertoupstream-blocked
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
ROCm/FastFlowLM#1057 ·
Los mantenedores suelen responder en 1 día
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
NatronGitHub/openfx-gmic#45 ·
Los mantenedores suelen responder en 1 día